Skip to content

Commit

Permalink
fix: misc undefined ts errors (#77)
Browse files Browse the repository at this point in the history
This fixes two warnings that were missed during 4cbcd8d
  • Loading branch information
ComradeVanti committed Dec 22, 2023
1 parent 5d6d4a7 commit 1a749f6
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion test/data-pkg-manifest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class PkgManifestBuilder {
scopedRegistry("example.com", exampleRegistryUrl),
];

const registry = this.manifest.scopedRegistries![0];
const registry = this.manifest.scopedRegistries![0]!;
addScope(registry, name);

return this;
Expand Down
14 changes: 8 additions & 6 deletions test/test-domain-name.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,14 @@ import should from "should";

describe("domain-name", function () {
describe("namespace", function () {
[
["unity.com", "com.unity"],
["my-school.ac.at", "at.ac.my-school"],
["openupm.com", "com.openupm"],
["registry.npmjs.org", "org.npmjs"],
].forEach(([hostName, expected]) =>
(
[
["unity.com", "com.unity"],
["my-school.ac.at", "at.ac.my-school"],
["openupm.com", "com.openupm"],
["registry.npmjs.org", "org.npmjs"],
] as [string, string][]
).forEach(([hostName, expected]) =>
it(`"${hostName}" should become "${expected}"`, function () {
const actual = namespaceFor(hostName);
should(actual).be.equal(expected);
Expand Down

0 comments on commit 1a749f6

Please sign in to comment.