refactor: shorten

src/services/login.ts

@@ -70,22 +70,15 @@ export function makeLogin(
     }
 
     // npm login
-    return npmLogin(registry, username, password, email).andThen((token) => {
+    return npmLogin(registry, username, password, email).map(async (token) => {
       debugLog(`npm login successful`);
-      // write npm token
-      return resultifyAsyncOp(authNpmrc(registry, token)).andThen(
-        (npmrcPath) => {
-          debugLog(`saved to npm config: ${npmrcPath}`);
-          // Save config
-          return resultifyAsyncOp(
-            saveAuthToUpmConfig(configPath, registry, {
-              email,
-              alwaysAuth,
-              token,
-            } satisfies TokenAuth)
-          );
-        }
-      );
+      const npmrcPath = await authNpmrc(registry, token);
+      debugLog(`saved to npm config: ${npmrcPath}`);
+      await saveAuthToUpmConfig(configPath, registry, {
+        email,
+        alwaysAuth,
+        token,
+      } satisfies TokenAuth);
     });
   };
 }

test/services/login.test.ts

@@ -124,23 +124,5 @@ describe("login", () => {
         }
       );
     });
-
-    it("should fail if config write fails", async () => {
-      const expected = new GenericIOError("Write");
-      const { login, saveAuthToUpmConfig } = makeDependencies();
-      saveAuthToUpmConfig.mockRejectedValue(expected);
-
-      const result = await login(
-        exampleUser,
-        examplePassword,
-        exampleEmail,
-        true,
-        exampleRegistryUrl,
-        exampleConfigPath,
-        "token"
-      ).promise;
-
-      expect(result).toBeError((actual) => expect(actual).toEqual(expected));
-    });
   });
 });