Skip to content

Commit

Permalink
deps: bump node to 18 (#315)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: This change bumps the projects node version to 18 because 16 is no longer maintained. See #282.
  • Loading branch information
ComradeVanti committed Apr 29, 2024
1 parent 804334e commit 51aa180
Show file tree
Hide file tree
Showing 8 changed files with 40 additions and 22 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x]
node-version: [18.x]
name: CI - node ${{ matrix.node-version }}
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
18
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16
v18
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ The command-line tool installs the 3rd-party registry as a scoped registry and m
## Installation

- Requires [nodejs 16 or above](https://nodejs.org/en/download/).
- Requires [nodejs 18 or above](https://nodejs.org/en/download/).
- Install via npm:

```
Expand Down Expand Up @@ -75,7 +75,7 @@ internal/modules/cjs/loader.js:818
Error: Cannot find module 'node:net'
```

Please install [Node.js 16 or above](https://nodejs.org/en/download/).
Please install [Node.js 18 or above](https://nodejs.org/en/download/).

## China region

Expand Down
4 changes: 2 additions & 2 deletions README.zh-cn.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ openupm-cli基于Unity对带作用域的软件仓库(scoped registry)的支
## 安装

- 请先自行安装[nodejs 16或以上版本](https://nodejs.org/en/download/).
- 请先自行安装[nodejs 18或以上版本](https://nodejs.org/en/download/).
- 通过npm安装:

```
Expand Down Expand Up @@ -74,7 +74,7 @@ internal/modules/cjs/loader.js:818
Error: Cannot find module 'node:net'
```

请安装[nodejs 16或以上版本](https://nodejs.org/en/download/)
请安装[nodejs 18或以上版本](https://nodejs.org/en/download/)


## 中国区
Expand Down
38 changes: 28 additions & 10 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"preferGlobal": true,
"description": "openupm command line interface",
"engines": {
"node": ">=16"
"node": ">=18"
},
"scripts": {
"test:full": "cross-env NODE_ENV=test jest",
Expand Down Expand Up @@ -42,7 +42,7 @@
"@types/fs-extra": "^11.0.3",
"@types/jest": "^29.5.12",
"@types/libnpmsearch": "^2.0.4",
"@types/node": "^16.18.68",
"@types/node": "^18.19.31",
"@types/node-fetch": "^2.6.9",
"@types/npmlog": "^4.1.4",
"@types/pkginfo": "^0.4.1",
Expand Down Expand Up @@ -86,6 +86,6 @@
"yaml": "^2.2.2"
},
"volta": {
"node": "16.20.2"
"node": "18.20.2"
}
}
4 changes: 2 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
// "disableReferencedProjectLoad": true, /* Reduce the number of projects loaded automatically by TypeScript. */

/* Language and Environment */
"target": "ES2020", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
"lib": ["ES2020"], /* Specify a set of bundled library declaration files that describe the target runtime environment. */
"target": "ES2022", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
"lib": ["ES2023"], /* Specify a set of bundled library declaration files that describe the target runtime environment. */
// "jsx": "preserve", /* Specify what JSX code is generated. */
// "experimentalDecorators": true, /* Enable experimental support for legacy experimental decorators. */
// "emitDecoratorMetadata": true, /* Emit design-type metadata for decorated declarations in source files. */
Expand Down

0 comments on commit 51aa180

Please sign in to comment.