Skip to content

Commit

Permalink
feat: remove manifest-path check from env
Browse files Browse the repository at this point in the history
Currently we check whether the manifest path exists during `parseEnv`.  This is really not necessary as all cmd functions have error handling logic in-case the manifest is missing.
  • Loading branch information
ComradeVanti committed Mar 20, 2024
1 parent 4622e68 commit b058bb3
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions src/utils/env.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {
ProjectVersionLoadError,
tryLoadProjectVersion,
} from "./project-version-io";
import { manifestPathFor } from "./project-manifest-io";
import { NotFoundError } from "./file-io";

export type Env = Readonly<{
Expand Down Expand Up @@ -142,16 +141,6 @@ export const parseEnv = async function (
}
const cwd = cwdResult.value;

// manifest path
const manifestPath = manifestPathFor(cwd);
if (!fs.existsSync(manifestPath)) {
log.error(
"manifest",
`can not locate manifest.json at path ${manifestPath}`
);
return Err(new NotFoundError(manifestPath));
}

// editor version
const projectVersionLoadResult = await tryLoadProjectVersion(cwd);
if (projectVersionLoadResult.isErr()) {
Expand Down

0 comments on commit b058bb3

Please sign in to comment.