feat: atomic package add #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when adding multiple packages using the `add` command, each will be added separately. That means, that if packages A, B and C are added and B fails for any reason, A and C will still be added to the manifest. With this change add operations are now atomic. In the same scenario as before, the manifest would not be modified, since one of the packages could not be added. A side-effect of this change is that `add` now only returns one error, instead of an array of them, since the first encountered error cancels the operation. See #223
|
@favoyang I would publish a new version for this, since it changes app behavior. Thoughts? |
ComradeVanti
added a commit
that referenced
this pull request
Apr 15, 2024
Makes removing multiple packages an atomic operation, as was recently implemented for the add command. See #234 for a longer explanation.
ComradeVanti
added a commit
that referenced
this pull request
Apr 15, 2024
Makes removing multiple packages an atomic operation, as was recently implemented for the add command. See #234 for a longer explanation.
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when adding multiple packages using the
addcommand, each will be added separately. That means, that if packages A, B and C are added and B fails for any reason, A and C will still be added to the manifest.With this change add operations are now atomic. In the same scenario as before, the manifest would not be modified, since one of the packages could not be added.
A side-effect of this change is that
addnow only returns one error, instead of an array of them, since the first encountered error cancels the operation.See #233