refactor: cmd-add manifest io #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when calling `add` with multiple packages, each will load, modify and save the project-manifest. This repeated loading and saving was necessary in case a package caused the app to crash, so that previous modifications would still be saved. For a while now, the app should no longer crash in regular use. Instead it will return error objects. This means we can now safely load and save the manifest only once.
|
@favoyang would love your feedback on this. Is there a reason I missed for loading/saving the manifest per package instead of once? |
favoyang
approved these changes
Apr 15, 2024
I agree with you that the add command should modify the manifest atomically. |
The way I implemented it now it is not atomic. If you install A, B and C and B fails, it will still install A and C. But I could also implement it truly atomic. Let me know. |
|
truly atomic would be great. |
|
Alright, will do. In a separate PR though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when calling
addwith multiple packages, each will load, modify and save the project-manifest. This repeated loading and saving was necessary in case a package caused the app to crash, so that previous modifications would still be saved.For a while now, the app should no longer crash in regular use. Instead it will return error objects. This means we can now safely load and save the manifest only once.