Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cmd-add manifest io #233

Merged
merged 2 commits into from
Apr 15, 2024
Merged

refactor: cmd-add manifest io #233

merged 2 commits into from
Apr 15, 2024

Commits on Apr 15, 2024

  1. refactor: cmd-add manifest io 

    Currently, when calling `add` with multiple packages, each will load, modify and save the project-manifest. This repeated loading and saving was necessary in case a package caused the app to crash, so that previous modifications would still be saved.

For a while now, the app should no longer crash in regular use. Instead it will return error objects. This means we can now safely load and save the manifest only once.
    @ComradeVanti
    ComradeVanti committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    79b2b7d View commit details
    Browse the repository at this point in the history

  2. fix: missing log

    @ComradeVanti
    ComradeVanti committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    87aff22 View commit details
    Browse the repository at this point in the history