-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: de-result unexpected errors #368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move io logic for text-files and directories into separate modules
a35115f
to
1c4ff4e
Compare
The PR also adds a few more error messages, so that is what I will merge it as |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
# [3.3.0](3.2.0...3.3.0) (2024-07-05) ### Features * add more error messages ([#368](#368)) ([44ba315](44ba315))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently most functions in the project use
Result
based return types. When I started to implement this I was of the opinion that all functions should use theResult
based workflow to allow for railway oriented programming.In the course of refactoring this project to use
Result
s I sometimes had a feeling that maybe some types of errors are not suitable to be used inResult
s. Recently I read this blog post which confirmed my suspicions and enhanced my understanding of error handling.In this PR I revert my over-zealous usage of
Result
s. They should now only be used for handle-able domain errors.