Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract table formatting #103

Merged
merged 3 commits into from
Jan 14, 2024
Merged

refactor: extract table formatting #103

merged 3 commits into from
Jan 14, 2024

Conversation

ComradeVanti
Copy link
Collaborator

Extracts logic for formatting packuments as a table to a separate module. The main benefits are:

  • The logic does not clutter the cmd-search module
  • Formatting logic can be reused by other commands
  • Other output formatting logic now has a module where it can be grouped

Extract logic for formatting packument for viewing into separate function.
Extract type that represents the version-part of a packument. Shorter than always rewriting the properties manually.
Extract table formatting logic to own module. This way other output formatting functions can be grouped together an reused.
@favoyang favoyang merged commit 1a049cf into openupm:master Jan 14, 2024
2 checks passed
@ComradeVanti ComradeVanti deleted the extract-table-formatting branch January 14, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants