Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make project-version io async #130

Merged
merged 1 commit into from
Jan 17, 2024
Merged

refactor: make project-version io async #130

merged 1 commit into from
Jan 17, 2024

Conversation

ComradeVanti
Copy link
Collaborator

Refactor the createProjectVersionTxt function async. Long running functions should be made async to avoid blocking.

@ComradeVanti
refactor: make function async
f31b7eb 
Refactor the `createProjectVersionTxt` function async. Long running functions should be made async to avoid blocking.
@ComradeVanti ComradeVanti changed the title refactor: make function async refactor: make project-version io async Jan 17, 2024
favoyang
favoyang approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@favoyang favoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks more consistent because setupUnityProject is an async function that shouldn't contain a block operation.

@favoyang favoyang merged commit 324c9bf into openupm:master Jan 17, 2024
2 checks passed
@ComradeVanti ComradeVanti deleted the async-project-version-io branch January 18, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@favoyang favoyang favoyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ComradeVanti @favoyang