Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad declaration file #320

Merged
merged 1 commit into from
May 2, 2024
Merged

fix: bad declaration file #320

merged 1 commit into from
May 2, 2024

Conversation

ComradeVanti
Copy link
Collaborator

The declaration files for npm-registry-fetch package do not expose the error-class it throws when a fetch failed. Because of this, we wrote our own declaration file for it.

The declaration file was incorrectly written. It placed the error class into the packages index file even though it is inside lib/errors. After updating the declaration and relevant imports the error is now fixed.

See #319.

The declaration files for `npm-registry-fetch` package do not expose the error-class it throws when a fetch failed. Because of this, we wrote our own declaration file for it.

The declaration file was incorrectly written. It placed the error class into the packages `index` file even though it is inside `lib/errors`. After updating the declaration and relevant imports the error is now fixed.

See #319.
@ComradeVanti ComradeVanti merged commit 3d6d888 into master May 2, 2024
4 checks passed
@ComradeVanti ComradeVanti deleted the fix-319 branch May 2, 2024 06:33
github-actions bot pushed a commit that referenced this pull request May 2, 2024
## [2.0.1](2.0.0...2.0.1) (2024-05-02)

### Bug Fixes

* bad declaration file ([#320](#320)) ([3d6d888](3d6d888)), closes [#319](#319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant