misc: reword log #384
Merged
misc: reword log #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log in question was printed when the upmconfig does not contain an entry for the primary registry. This is usually expected, since usually the primary registry is openupm and you dont need auth for it. Still you would get a warning that openupm could not be parsed. But actually this log just means that there was no entry. The log was now reworded and also is only shown on the verbose level. Also we now only show this log when using a custom registry, since, again, openupm will never need auth.
ComradeVanti
force-pushed
the
upm-config-log
branch
from
86d50c2
to
454a9cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log in question was printed when the upmconfig does not contain an entry for the primary registry. This is usually expected, since usually the primary registry is openupm and you dont need auth for it. Still you would get a warning that openupm could not be parsed. But actually this log just means that there was no entry.
The log was now reworded and also is only shown on the verbose level. Also we now only show this log when using a custom registry, since, again, openupm will never need auth.