feat: add global options deprecation warnings #410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: As part of ac31f01 global options which are only relevant to some commands have been moved to those specific commands. This left some users confused, because this was done without warning or major version change. This change seeks to remedy this, by adding deprecation warnings as well as triggering a major version bump.
|
It seems like it is not possible to implement this because of a limitation of commander. It can't figure out how to detect whether an option was specified on the global command or on a specific sub-command. we either always get the deprecation warning, or never. I'll abandon this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
As part of ac31f01 global options which are only relevant to some commands have been moved to those specific commands.
This left some users confused, because this was done without warning or major version change. This change seeks to remedy this, by adding deprecation warnings as well as triggering a major version bump.