Skip to content

Commit

Permalink
update tests
Browse files Browse the repository at this point in the history
  • Loading branch information
CFenner committed Apr 3, 2024
1 parent 48acb22 commit fe50418
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 14 deletions.
3 changes: 1 addition & 2 deletions tests/test_Solar.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import unittest

from PyViCare.PyViCareHeatingDevice import HeatingDevice
from PyViCare.PyViCareUtils import PyViCareNotSupportedFeatureError
from tests.ViCareServiceMock import ViCareServiceMock


Expand Down Expand Up @@ -49,4 +48,4 @@ def test_isSolarThermalDevice(self):
self.assertTrue(self.device.isSolarThermalDevice())

def test_isVentilationDevice(self):
self.assertRaises(PyViCareNotSupportedFeatureError, self.device.isVentilationDevice)
self.assertFalse(self.device.isVentilationDevice())
7 changes: 3 additions & 4 deletions tests/test_VitoairFs300E.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import unittest
from PyViCare.PyViCareUtils import PyViCareNotSupportedFeatureError

from PyViCare.PyViCareVentilationDevice import VentilationDevice
from tests.ViCareServiceMock import ViCareServiceMock
Expand Down Expand Up @@ -32,13 +31,13 @@ def test_getSerial(self):
self.assertEqual(self.device.getSerial(), "################")

def test_isHeatingDevice(self):
self.assertRaises(PyViCareNotSupportedFeatureError, self.device.isHeatingDevice)
self.assertFalse(self.device.isHeatingDevice())

def test_isDomesticHotWaterDevice(self):
self.assertRaises(PyViCareNotSupportedFeatureError, self.device.isDomesticHotWaterDevice)
self.assertFalse(self.device.isDomesticHotWaterDevice())

def test_isSolarThermalDevice(self):
self.assertRaises(PyViCareNotSupportedFeatureError, self.device.isSolarThermalDevice)
self.assertFalse(self.device.isSolarThermalDevice())

def test_isVentilationDevice(self):
self.assertTrue(self.device.isVentilationDevice())
3 changes: 1 addition & 2 deletions tests/test_Vitocal222S.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import unittest

from PyViCare.PyViCareHeatPump import HeatPump
from PyViCare.PyViCareUtils import PyViCareNotSupportedFeatureError
from tests.helper import now_is
from tests.ViCareServiceMock import ViCareServiceMock

Expand All @@ -27,7 +26,7 @@ def test_isDomesticHotWaterDevice(self):
self.assertTrue(self.device.isDomesticHotWaterDevice())

def test_isSolarThermalDevice(self):
self.assertRaises(PyViCareNotSupportedFeatureError, self.device.isSolarThermalDevice)
self.assertFalse(self.device.isSolarThermalDevice())

def test_isVentilationDevice(self):
self.assertTrue(self.device.isVentilationDevice())
5 changes: 2 additions & 3 deletions tests/test_Vitodens200W.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import unittest

from PyViCare.PyViCareGazBoiler import GazBoiler
from PyViCare.PyViCareUtils import PyViCareNotSupportedFeatureError
from tests.helper import now_is
from tests.ViCareServiceMock import ViCareServiceMock

Expand Down Expand Up @@ -101,7 +100,7 @@ def test_isDomesticHotWaterDevice(self):
self.assertTrue(self.device.isDomesticHotWaterDevice())

def test_isSolarThermalDevice(self):
self.assertRaises(PyViCareNotSupportedFeatureError, self.device.isSolarThermalDevice)
self.assertFalse(self.device.isSolarThermalDevice())

def test_isVentilationDevice(self):
self.assertRaises(PyViCareNotSupportedFeatureError, self.device.isVentilationDevice)
self.assertFalse(self.device.isVentilationDevice())
5 changes: 2 additions & 3 deletions tests/test_Vitovent.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import unittest

from PyViCare.PyViCareUtils import PyViCareNotSupportedFeatureError
from PyViCare.PyViCareVentilationDevice import VentilationDevice
from tests.ViCareServiceMock import ViCareServiceMock

Expand All @@ -11,13 +10,13 @@ def setUp(self):
self.device = VentilationDevice(self.service)

def test_isHeatingDevice(self):
self.assertRaises(PyViCareNotSupportedFeatureError, self.device.isHeatingDevice)
self.assertFalse(self.device.isHeatingDevice())

def test_isDomesticHotWaterDevice(self):
self.assertTrue(self.device.isDomesticHotWaterDevice())

def test_isSolarThermalDevice(self):
self.assertRaises(PyViCareNotSupportedFeatureError, self.device.isSolarThermalDevice)
self.assertFalse(self.device.isSolarThermalDevice())

def test_isVentilationDevice(self):
self.assertTrue(self.device.isVentilationDevice())

0 comments on commit fe50418

Please sign in to comment.