Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value for target in prune cli #1253

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

sooahleex
Copy link
Contributor

@sooahleex sooahleex commented Jan 31, 2024

Summary

How to test

  • Use existed cli test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sooahleex sooahleex marked this pull request as ready for review January 31, 2024 02:24
@sooahleex sooahleex requested review from a team as code owners January 31, 2024 02:24
@sooahleex sooahleex requested review from wonjuleee and removed request for a team January 31, 2024 02:24
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a819dbb) 80.57% compared to head (1521b49) 80.57%.

Files Patch % Lines
src/datumaro/cli/commands/prune.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1253   +/-   ##
========================================
  Coverage    80.57%   80.57%           
========================================
  Files          271      271           
  Lines        30441    30442    +1     
  Branches      5930     5930           
========================================
+ Hits         24528    24529    +1     
  Misses        4525     4525           
  Partials      1388     1388           
Flag Coverage Δ
ubuntu-20.04_Python-3.8 80.55% <33.33%> (+<0.01%) ⬆️
windows-2022_Python-3.8 80.54% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wonjuleee wonjuleee merged commit acc491d into openvinotoolkit:develop Feb 1, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants