Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scikit-image from dependencies #379

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Remove scikit-image from dependencies #379

merged 1 commit into from
Jul 23, 2021

Conversation

IRDonch
Copy link

@IRDonch IRDonch commented Jul 23, 2021

Summary

The sole usage of it was removed in ce0a122.

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

The sole usage of it was removed in ce0a122.
@@ -17,7 +17,7 @@ pycocotools>=2.0.0,!=2.0.2; platform_system != "Windows"

pycocotools-windows; platform_system == "Windows"
PyYAML>=5.3.1
scikit-image>=0.15.0
scipy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a version restriction?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly, no, because Datumaro only uses a single SciPy function, scipy.linalg.orth, which was added before Python 3 even existed. :-)

@IRDonch IRDonch merged commit 4bbd346 into openvinotoolkit:develop Jul 23, 2021
@IRDonch IRDonch deleted the rm-skimage branch July 23, 2021 15:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants