Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested fix for issue #560 #564

Merged
merged 3 commits into from
Nov 24, 2021

Conversation

maartenvds
Copy link
Contributor

Summary

Resolves issue (bug) #560
With this fix, the following issue in CVAT will also be resolved and does not need further changes: cvat-ai/cvat#3940

How to test

This was tested manually through the CVAT tool:

  1. Create a new project and upload a video
  2. Open the task
  3. Click Actions -> upload annotations -> MOT 1.1
  4. Select zip folder with MOT annotation format (including seqinfo.ini file) and click 'upload'

With this PR, importing should succeed

Checklist

@zhiltsov-max
Copy link
Contributor

zhiltsov-max commented Nov 24, 2021

  1. Could you please add a test using seqinfo file in https://github.com/openvinotoolkit/datumaro/blob/develop/tests/test_mot_format.py? Probably, with an example directory in https://github.com/openvinotoolkit/datumaro/tree/develop/tests/assets/mot_dataset.

  2. Please add a line in changelog.

@maartenvds
Copy link
Contributor Author

  1. Could you please add a test using seqinfo file in https://github.com/openvinotoolkit/datumaro/blob/develop/tests/test_mot_format.py? Probably, with an example directory in https://github.com/openvinotoolkit/datumaro/tree/develop/tests/assets/mot_dataset.

Done. I added a new assets folder without an img1 directory and with a seqinfo.ini file. I appended a test case in test_mot_format.py that checks if the import works and that all imported fields are as expected. The test fails if I remove my change to mot_format.py.

2. Please add a line in changelog.

Done.

@zhiltsov-max zhiltsov-max merged commit b700444 into openvinotoolkit:develop Nov 24, 2021
@zhiltsov-max
Copy link
Contributor

Thank you for the contribution!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading MOT dataset with seqinfo produces 0-based indexing in frames
2 participants