-
Notifications
You must be signed in to change notification settings - Fork 10
Cythonize AugMixAugment #126
Cythonize AugMixAugment #126
Conversation
vinnamkim
commented
Jan 2, 2023
- Cythonize AugMixAugment
- Add unit tests
Hi @vinnamkim! Could you please provide some data about the performance improvement that brings the cythonized code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update. BTW, we've recently merged MPA otx branch to OTE feature/otx branch. openvinotoolkit/training_extensions#1464.
Could you retarget this PR to OTE repo?
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
926f26e
to
ee74be0
Compare
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Hi, I sent you page links about it on Teams. Please feel free to ask me if you have questions. |
I changed this PR's target branch to apply this change to OTE 0.5.0 |
Thank you Vinnam. Then, would you create yet another PR to OTE develop branch to change MPA commit? At least, I'd recommend to create a draft PR to execute OTE CI with this change. (OTE feature/otx branch will run github action CI test.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is related to OTEv0.5.0 and there are no FAIL cases in CI tests.
Report is here: http://validationreports.sclab.intel.com:8006/reports/build_number_report?test_session_build_number=pr-ote-test-866&environment=iotg-dev-workstation-08
And there is also another PR to target the feature/otx
branch. So, we can merge this PR. What do you think? @goodsong81
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me