Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Cythonize AugMixAugment #126

Merged

Conversation

vinnamkim
Copy link
Contributor

  • Cythonize AugMixAugment
  • Add unit tests

@sovrasov
Copy link
Contributor

sovrasov commented Jan 2, 2023

Hi @vinnamkim! Could you please provide some data about the performance improvement that brings the cythonized code?

Copy link
Collaborator

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. BTW, we've recently merged MPA otx branch to OTE feature/otx branch. openvinotoolkit/training_extensions#1464.
Could you retarget this PR to OTE repo?

@wonjuleee wonjuleee self-requested a review January 3, 2023 01:32
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim force-pushed the vinnamki/integrate-cython-augmix branch from 926f26e to ee74be0 Compare January 3, 2023 06:43
@vinnamkim vinnamkim changed the base branch from otx to develop January 3, 2023 06:44
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Copy link
Contributor Author

Hi @vinnamkim! Could you please provide some data about the performance improvement that brings the cythonized code?

Hi, I sent you page links about it on Teams. Please feel free to ask me if you have questions.

@vinnamkim
Copy link
Contributor Author

Thank you for the update. BTW, we've recently merged MPA otx branch to OTE feature/otx branch. openvinotoolkit/training_extensions#1464. Could you retarget this PR to OTE repo?

I changed this PR's target branch to apply this change to OTE 0.5.0 develop branch, and I'll also make another PR in OTE repo for feature/otx branch.

@goodsong81
Copy link
Collaborator

Thank you for the update. BTW, we've recently merged MPA otx branch to OTE feature/otx branch. openvinotoolkit/training_extensions#1464. Could you retarget this PR to OTE repo?

I changed this PR's target branch to apply this change to OTE 0.5.0 develop branch, and I'll also make another PR in OTE repo for feature/otx branch.

Thank you Vinnam. Then, would you create yet another PR to OTE develop branch to change MPA commit? At least, I'd recommend to create a draft PR to execute OTE CI with this change. (OTE feature/otx branch will run github action CI test.)

Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is related to OTEv0.5.0 and there are no FAIL cases in CI tests.
Report is here: http://validationreports.sclab.intel.com:8006/reports/build_number_report?test_session_build_number=pr-ote-test-866&environment=iotg-dev-workstation-08

And there is also another PR to target the feature/otx branch. So, we can merge this PR. What do you think? @goodsong81

Copy link

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@goodsong81 goodsong81 merged commit fe90e91 into openvinotoolkit:develop Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants