-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Good First Issue]: Align behavior of ONNX Frontend function ReduceLogSum-11, 13, 18 with original framework #20561
Comments
Hi! I'm a first time contributor. Could this issue be assigned to me? |
It's yours now :) |
Hello @Hunter-bitbit, do you need any help from us? :) |
Hi @p-wysocki, some help would be great, yes. I'm mostly just having issues with understanding what needs to be done. I made the table of differences between versions, but steps 2 and 3 don't make much sense to me. I found the existing implementation but I don't know where to copy it to? For the registration I found a ReducedLogSum in there... do I have to specify the namespace it's in? I'm just very confused as to what I actually have to do since it seems like everything is already implemented... sorry for the hassle :\ |
Hello @Hunter-bitbit, it may be the case that the operator is currently correctly aligned. Could you please give a brief summary of the changes between op versions and what OpenVINO has? That would simplify the discussion a lot. cc @gkrivor |
.take |
Thank you for looking into this issue! Please let us know if you have any questions or require any help. |
Hi, |
### Details: - Extended ReduceLogSum by opsets 11,13,18 ### Tickets: - Closes #20561 --------- Co-authored-by: Katarzyna Mitrus <katarzyna.mitrus@intel.com> Co-authored-by: Georgy Krivoruchko <georgy.krivoruchko@intel.com>
### Details: - Extended ReduceLogSum by opsets 11,13,18 ### Tickets: - Closes openvinotoolkit#20561 --------- Co-authored-by: Katarzyna Mitrus <katarzyna.mitrus@intel.com> Co-authored-by: Georgy Krivoruchko <georgy.krivoruchko@intel.com>
### Details: - Extended ReduceLogSum by opsets 11,13,18 ### Tickets: - Closes openvinotoolkit#20561 --------- Co-authored-by: Katarzyna Mitrus <katarzyna.mitrus@intel.com> Co-authored-by: Georgy Krivoruchko <georgy.krivoruchko@intel.com>
Context
Neural networks are graphs consisting of nodes called operators. Each operator corresponds to a mathematical function, usually described in framework's documentation or an AI standard, such as ONNX.
OpenVINO ONNX Frontend is a component responsible for working with ONNX graphs and requires implementation of different ONNX operators in order to use ONNX models.
This task requires alignment between OpenVINO ONNX Frontend and original framework implementations of ReduceLogSum for next list of opsets: opset 11, opset 13, opset 18
Necessary help will be provided by ONNX Fronted team.
What needs to be done?
First of all, please, take a look on ReduceMax PR for a reference.
Operator details can be found in ONNX Operators
More details can be found in ONNX Changelog: opset 11, opset 13, opset 18
More details in adding operators to ONNX Frontend guide
Example Pull Requests
No response
Resources
Contact points
@gkrivor
Ticket
No response
The text was updated successfully, but these errors were encountered: