Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mish op to ngraph #1187

Conversation

iimironov
Copy link
Contributor

No description provided.

@iimironov iimironov requested a review from a team July 2, 2020 12:51
Copy link
Contributor

@tomdol tomdol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sin you've implemented the evaluate method for this new op, can you add at least one test that checks the calculated values?

@ilya-lavrenov ilya-lavrenov added the category: Core OpenVINO Core (aka ngraph) label Jul 8, 2020
@ilya-lavrenov ilya-lavrenov added this to the 2021.1 milestone Jul 8, 2020
@iimironov iimironov force-pushed the imironov/CVS-32956-add-mish-op-to-ngraph branch from 19ae60f to 70441e9 Compare July 9, 2020 09:42
ngraph/src/ngraph/op/mish.hpp Outdated Show resolved Hide resolved
ngraph/src/ngraph/op/mish.hpp Outdated Show resolved Hide resolved
ngraph/src/ngraph/runtime/reference/mish.hpp Outdated Show resolved Hide resolved
ngraph/src/ngraph/op/mish.hpp Outdated Show resolved Hide resolved
ngraph/test/op_eval/mish.cpp Outdated Show resolved Hide resolved
ngraph/test/type_prop/mish.cpp Show resolved Hide resolved
@iimironov iimironov force-pushed the imironov/CVS-32956-add-mish-op-to-ngraph branch from c010e93 to 86bc573 Compare July 13, 2020 17:06
@iimironov iimironov requested a review from ilyachur July 15, 2020 13:53
Your Name added 3 commits July 16, 2020 09:47
Your Name added 2 commits July 17, 2020 10:45
@GlebKazantaev GlebKazantaev merged commit 399c7bf into openvinotoolkit:master Jul 20, 2020
xuchen-intel pushed a commit to xuchen-intel/openvino that referenced this pull request Jul 21, 2020
* Add mish op to ngraph

* Update mish op

* Set v4 namespase for tests

* Add mish to cmake

* Add comments for mish op.

* Refactoring code style

* Update version to v1 for Mish op

* Add value propogation test for Mish op

* Refactoring mish op according to review

* Fix mish version

* Update cmake file

* Fix mish value propogation unit test

* Add unit test for mish op

Co-authored-by: Your Name <you@example.com>
@@ -153,4 +154,4 @@ NGRAPH_OP(TopK, ngraph::op::v3)

// New operations added in opset4
NGRAPH_OP(NonMaxSuppression, ngraph::op::v4)
NGRAPH_OP(Acosh, ngraph::op::v3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this line?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was moved to new place (in alphabet order).

RomanZm pushed a commit to RomanZm/openvino that referenced this pull request Aug 28, 2020
* Add mish op to ngraph

* Update mish op

* Set v4 namespase for tests

* Add mish to cmake

* Add comments for mish op.

* Refactoring code style

* Update version to v1 for Mish op

* Add value propogation test for Mish op

* Refactoring mish op according to review

* Fix mish version

* Update cmake file

* Fix mish value propogation unit test

* Add unit test for mish op

Co-authored-by: Your Name <you@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants