-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mish op to ngraph #1187
Add mish op to ngraph #1187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sin you've implemented the evaluate
method for this new op, can you add at least one test that checks the calculated values?
19ae60f
to
70441e9
Compare
c010e93
to
86bc573
Compare
…mironov/CVS-32956-add-mish-op-to-ngraph
…mironov/CVS-32956-add-mish-op-to-ngraph
…mironov/CVS-32956-add-mish-op-to-ngraph
…mironov/CVS-32956-add-mish-op-to-ngraph
…mironov/CVS-32956-add-mish-op-to-ngraph
…mironov/CVS-32956-add-mish-op-to-ngraph
* Add mish op to ngraph * Update mish op * Set v4 namespase for tests * Add mish to cmake * Add comments for mish op. * Refactoring code style * Update version to v1 for Mish op * Add value propogation test for Mish op * Refactoring mish op according to review * Fix mish version * Update cmake file * Fix mish value propogation unit test * Add unit test for mish op Co-authored-by: Your Name <you@example.com>
@@ -153,4 +154,4 @@ NGRAPH_OP(TopK, ngraph::op::v3) | |||
|
|||
// New operations added in opset4 | |||
NGRAPH_OP(NonMaxSuppression, ngraph::op::v4) | |||
NGRAPH_OP(Acosh, ngraph::op::v3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line was moved to new place (in alphabet order).
* Add mish op to ngraph * Update mish op * Set v4 namespase for tests * Add mish to cmake * Add comments for mish op. * Refactoring code style * Update version to v1 for Mish op * Add value propogation test for Mish op * Refactoring mish op according to review * Fix mish version * Update cmake file * Fix mish value propogation unit test * Add unit test for mish op Co-authored-by: Your Name <you@example.com>
No description provided.