Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deprecated API] Remove api set_element_type() in ov::descriptor::Tensor #22476

Closed
wants to merge 9 commits into from
Closed

[Deprecated API] Remove api set_element_type() in ov::descriptor::Tensor #22476

wants to merge 9 commits into from

Conversation

zhaixuejun1993
Copy link
Contributor

@zhaixuejun1993 zhaixuejun1993 commented Jan 28, 2024 •
edited
Loading

Details:

  • Deprecated API set_element_type()
  • Deprecated API set_tensor_type()
  • ...

Tickets:

@zhaixuejun1993 zhaixuejun1993 requested review from a team as code owners January 28, 2024 03:04
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common category: transformations OpenVINO Runtime library - Transformations category: CPP API OpenVINO CPP API bindings labels Jan 28, 2024
@zhaixuejun1993 zhaixuejun1993 force-pushed the xuejun/deprecated_1.0_part4 branch from b41277d to 7be1980 Compare January 30, 2024 08:50
vurusovs
vurusovs reviewed Jan 30, 2024
View reviewed changes
src/tests/functional/shared_test_classes/src/subgraph/memory_LSTMCell.cpp
Comment on lines -277 to -278
out_hidden.get_tensor().set_element_type(element_type);
out_cell.get_tensor().set_element_type(element_type);
Copy link
Contributor

@vurusovs vurusovs Jan 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itikhono was set_element_type() really required? May it be just removed from test instead of replacing?

@zhaixuejun1993 zhaixuejun1993 requested a review from a team as a code owner January 30, 2024 14:37
@github-actions github-actions bot added the category: inference OpenVINO Runtime library - Inference label Jan 30, 2024
@zhaixuejun1993
Fix warning as error
66ba756 
Signed-off-by: Zhai, Xuejun <xuejun.zhai@intel.com>
@zhaixuejun1993 zhaixuejun1993 requested a review from a team as a code owner January 31, 2024 02:12
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Jan 31, 2024
@github-actions github-actions bot removed category: inference OpenVINO Runtime library - Inference category: PyTorch FE OpenVINO PyTorch Frontend labels Jan 31, 2024
@zhaixuejun1993 zhaixuejun1993 changed the title [WIP][Deprecated API] Remove api set_element_type() in ov::descriptor::Tensor [Deprecated API] Remove api set_element_type() in ov::descriptor::Tensor Feb 1, 2024
@zhaixuejun1993
Fix error
8853bc6 
Signed-off-by: Zhai, Xuejun <xuejun.zhai@intel.com>
zhaixuejun1993
zhaixuejun1993 commented Feb 2, 2024
View reviewed changes
src/core/src/node.cpp
for (auto& item : get_output_descriptor(i).get_tensor_ptr()->get_rt_info()) {
tmp_tensor->get_rt_info()[item.first] = item.second;
}
get_output_descriptor(i).set_tensor_ptr(tmp_tensor);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilya-lavrenov @vurusovs Why we need to deprecated this API? Seems like this change will take more time & more complex.

@peterchen-intel
Copy link
Contributor

Replaced by #22645

@zhaixuejun1993 zhaixuejun1993 deleted the xuejun/deprecated_1.0_part4 branch March 26, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vurusovs vurusovs vurusovs left review comments

@ilya-lavrenov ilya-lavrenov ilya-lavrenov left review comments

@mmikolajcz mmikolajcz Awaiting requested review from mmikolajcz mmikolajcz was automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@PiotrKrzem PiotrKrzem Awaiting requested review from PiotrKrzem PiotrKrzem was automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

Assignees

@ilya-lavrenov ilya-lavrenov

@vurusovs vurusovs

Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: IE Tests OpenVINO Test: plugins and common category: transformations OpenVINO Runtime library - Transformations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhaixuejun1993 @peterchen-intel @ilya-lavrenov @vurusovs