Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the aten::mv for pytorch models #22073 #22677
Fix the aten::mv for pytorch models #22073 #22677
Changes from 17 commits
8d1df2a
50a88a9
09ffcf7
c9f3153
22445f3
7b16b31
0b62932
02651e4
a4b248b
4a57553
741f246
d66b919
d5530e0
31ecd9d
c4e091c
62a3440
e59389d
256fc21
4aeeb12
bb33e2d
c74d626
ba01e70
df0162a
a9100e0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test does not cover the operation you are supporting, it tests that there is aten::mm in the graph instead of aten::mv.
For having your operation in model you need to call torch.mv instead of torch.matmul
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove device, you don't use it. Also add some more shapes for tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add maybe 1 or 2 more test cases for non-square matrix and 3x3 matrix