Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] [ARM] JIT Floor #24041

Merged
merged 2 commits into from
May 31, 2024
Merged

[CPU] [ARM] JIT Floor #24041

merged 2 commits into from
May 31, 2024

Conversation

eshoguli
Copy link
Contributor

Details:

  • [CPU] [ARM] jit floor

Tickets:

@eshoguli eshoguli requested review from a team as code owners April 15, 2024 22:46
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Apr 15, 2024
@eshoguli eshoguli added platform: arm OpenVINO on ARM / ARM64 and removed category: CPU OpenVINO CPU plugin labels Apr 15, 2024
@eshoguli eshoguli added this to the 2024.2 milestone Apr 15, 2024
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Apr 15, 2024
@eshoguli eshoguli changed the title [DEBUG] [CPU] [ARM] [X64] jit floor [CPU] [ARM] jit floor Apr 15, 2024
@eshoguli eshoguli force-pushed the es/cpu/jit_floor branch 2 times, most recently from 0539b6d to e295205 Compare April 16, 2024 12:40
@dmitry-gorokhov
Copy link
Contributor

  1. Could you please add support for x64 jit emitter? Just want to avoid unaligned support between device wherever possible
  2. Don't we need to update tests? Or floor is covered already?

@eshoguli eshoguli changed the title [CPU] [ARM] jit floor [CPU] [ARM] JIT Floor Apr 22, 2024
@eshoguli
Copy link
Contributor Author

eshoguli commented May 8, 2024

  1. Could you please add support for x64 jit emitter? Just want to avoid unaligned support between device wherever possible
  2. Don't we need to update tests? Or floor is covered already?

Tests were added, thanks. CVS-140753 for X64 was created.

@dmitry-gorokhov
Copy link
Contributor

  1. Could you please add support for x64 jit emitter? Just want to avoid unaligned support between device wherever possible
  2. Don't we need to update tests? Or floor is covered already?

Tests were added, thanks. CVS-140753 for X64 was created.

I mean lets implement x64 emitter in bounds of this PR. Should be pretty straightforward to do that.

@eshoguli eshoguli force-pushed the es/cpu/jit_floor branch 2 times, most recently from 30cd4be to 9d6532b Compare May 13, 2024 18:34
@eshoguli
Copy link
Contributor Author

I mean lets implement x64 emitter in bounds of this PR. Should be pretty straightforward to do that.

x64, supported

@eshoguli eshoguli force-pushed the es/cpu/jit_floor branch 2 times, most recently from 82694ec to 58c1c94 Compare May 16, 2024 09:31
@eshoguli eshoguli force-pushed the es/cpu/jit_floor branch 2 times, most recently from c0c52b7 to 78065e6 Compare May 19, 2024 18:03
@eshoguli eshoguli force-pushed the es/cpu/jit_floor branch 2 times, most recently from 4ba1bbb to 9f1b7e7 Compare May 20, 2024 11:12
@dmitry-gorokhov dmitry-gorokhov removed this from the 2024.2 milestone May 23, 2024
@dmitry-gorokhov dmitry-gorokhov added this to the 2024.3 milestone May 23, 2024
@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue May 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 30, 2024
@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue May 31, 2024
Merged via the queue into openvinotoolkit:master with commit 33bbfd1 May 31, 2024
111 checks passed
@dmitry-gorokhov dmitry-gorokhov deleted the es/cpu/jit_floor branch May 31, 2024 12:35
mory91 pushed a commit to mory91/openvino that referenced this pull request Jun 3, 2024
@eshoguli @mory91
[CPU] [ARM] JIT Floor (openvinotoolkit#24041)
805a7ac 
### Details:
 - *[CPU] [ARM] jit floor*

### Tickets:
 - *CVS-138572*
allnes pushed a commit to allnes/openvino that referenced this pull request Jun 27, 2024
@eshoguli @allnes
[CPU] [ARM] JIT Floor (openvinotoolkit#24041)
2b24dc3 
### Details:
 - *[CPU] [ARM] jit floor*

### Tickets:
 - *CVS-138572*
@dmitry-gorokhov dmitry-gorokhov mentioned this pull request Oct 21, 2024
Open
This was referenced Nov 11, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

Assignees

@dmitry-gorokhov dmitry-gorokhov

@xuchen-intel xuchen-intel

Labels
category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64
Projects
None yet
Milestone
2024.3
Development

Successfully merging this pull request may close these issues.
3 participants
@eshoguli @dmitry-gorokhov @xuchen-intel