[PT FE] Add aten::rrelu

[AdamPSU]

Details:

• Add support for aten::rrelu

Tickets:

• 23746

[AdamPSU]

Feedback? This is my first contribution to anything, really, so apologies if things are a bit messy. A few points:

I accidentally pushed changes to cmake/developer_package/frontends/frontends.cmake. I take it I'm supposed to remove those, correct?

Also, I’m encountering the following error:

CMake Error at cmake/developer_package/frontends/frontends.cmake:195 (add_library):
Cannot find source file: ../../../src/frontends/pytorch/src/op/rrelu.cpp

Does this indicate an issue with my build setup?

Am I on the right track with this PR? I realize I’m missing aten::rrelu_ and tests, but I’m hoping to get feedback before proceeding further.

Thanks for your help!

[mvafin]

@AdamPSU Sorry for delayed response. You were going in the right direction, why did you close the PR? Do you to continue it?

[AdamPSU]

I got cold feet and feared I was doing something wrong... But it's reassuring hearing you say this. I'm willing to open the PR again, though confirmation to the following would be great:

1.) Is something wrong with my build (refer to the above discussion post)
2.) Is there a simple way to test my code? It felt like I was coding blindholded, haha...

[mvafin]

I got cold feet and feared I was doing something wrong... But it's reassuring hearing you say this. I'm willing to open the PR again, though confirmation to the following would be great:

1.) Is something wrong with my build (refer to the above discussion post) 2.) Is there a simple way to test my code? It felt like I was coding blindholded, haha...

1. You are right, you do not need to modify .cmake file. It should pick up when you run cmake automatically.
2. Yes, you can test your code. First you need to add your operation in the list of supported operations here: https://github.com/openvinotoolkit/openvino/blob/master/src/frontends/pytorch/src/op_table.cpp
   After that please add test for rrelu here https://github.com/openvinotoolkit/openvino/tree/master/tests/layer_tests/pytorch_tests
   You can use a similar test as reference, for example: https://github.com/openvinotoolkit/openvino/blob/master/tests/layer_tests/pytorch_tests/test_clamp.py
   To run the test locally you can refer here: https://github.com/openvinotoolkit/openvino/blob/master/tests/layer_tests/README.md
   It is only required to run test on CPU with FP32 precision.

You do not need to add aten::rrelu_ for now, it should work automatically now, but you need to add tests for it.

[mvafin]

lower and upper are the inputs, so please use context.get_input to get them.

[AdamPSU]

Will there always be inputs? According to the documentation for rrelu, if the inputs are omitted, lower is set to 1/8 and upper is 1/3.

[mvafin]

No, it is not guaranteed, so you need to check if they are present using input_is_none

[mvafin]

Remove this change please

[AdamPSU]

Thanks -- a bit busy because of exams, but I'll get to this on Thursday. May take me a couple of days, but I'll try my best. Thanks for the patience, and I'll be sure to write those test cases. :)

[mvafin]

Thanks -- a bit busy because of exams, but I'll get to this on Thursday. May take me a couple of days, but I'll try my best. Thanks for the patience, and I'll be sure to write those test cases. :)

Okay, no worries

[AdamPSU]

@mvafin Feel free to take a look at some of the changes; I believe I'm done with aten::rrelu. I intend to experiment with the test cases later tonight.