-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial Value Optimization #27555
Open
jane-intel
wants to merge
10
commits into
openvinotoolkit:master
Choose a base branch
from
jane-intel:partial_value_optimization
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Partial Value Optimization #27555
jane-intel
wants to merge
10
commits into
openvinotoolkit:master
from
jane-intel:partial_value_optimization
+147
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
github-actions
bot
added
the
category: transformations
OpenVINO Runtime library - Transformations
label
Nov 14, 2024
praasz
reviewed
Nov 14, 2024
src/common/transformations/src/transformations/symbolic_transformations/symbol_optimization.cpp
Outdated
Show resolved
Hide resolved
src/common/transformations/src/transformations/symbolic_transformations/symbol_optimization.cpp
Outdated
Show resolved
Hide resolved
src/common/transformations/src/transformations/symbolic_transformations/symbol_optimization.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
…imization Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
…imization Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
praasz
reviewed
Nov 22, 2024
continue; | ||
auto symbol = d.get_symbol(); | ||
if (symbol == nullptr) | ||
if (d.is_static() || d.get_symbol() == nullptr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if (d.is_static() || d.get_symbol() == nullptr) | |
if (d.is_static() || !d.has_symbol()) |
Maybe has_symbol
should be updated and static Dimension shouldn't have symbol?
Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
…imization Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: CPU
OpenVINO CPU plugin
category: transformations
OpenVINO Runtime library - Transformations
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details: