Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Value Optimization #27555

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jane-intel
Copy link
Contributor

Details:

  • Partial Value optimization was already capable of optimizing multiple value sources. This time we strive to reuse singular values in the construction of multi-values so that we minimize ShapeOf op number and minimize ShapeOf sub-graphs. Additionally, this time we prioritize static values over symbol for the case when value has both

Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
@jane-intel jane-intel requested a review from a team as a code owner November 14, 2024 09:34
@jane-intel jane-intel requested review from itikhono and removed request for a team November 14, 2024 09:34
@github-actions github-actions bot added the category: transformations OpenVINO Runtime library - Transformations label Nov 14, 2024
Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
…imization

Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
…imization

Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
continue;
auto symbol = d.get_symbol();
if (symbol == nullptr)
if (d.is_static() || d.get_symbol() == nullptr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (d.is_static() || d.get_symbol() == nullptr)
if (d.is_static() || !d.has_symbol())

Maybe has_symbol should be updated and static Dimension shouldn't have symbol?

Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
…imization

Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
@jane-intel jane-intel requested review from a team as code owners November 23, 2024 07:36
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin category: transformations OpenVINO Runtime library - Transformations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants