Fix support of "inputs_embeds" input of VLMs in SDPAToPA transformation #28674
+576
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuriousPanCake
changed the title
github-actions
bot
added
the
category: transformations
itikhono
reviewed
Jan 27, 2025
| // for "input_ids" | ||
| processed_input_ids = input_ids_node; | ||
| } else { | ||
| OPENVINO_ASSERT(processed_input_ids, "Counln't process neither input_ids, nor inputs_embeds."); |
There was a problem hiding this comment.
Suggested change
| OPENVINO_ASSERT(processed_input_ids, "Counln't process neither input_ids, nor inputs_embeds."); | |
| OPENVINO_ASSERT(processed_input_ids, "Couldn't process neither input_ids, nor inputs_embeds."); |
itikhono
reviewed
Jan 27, 2025
| for (const auto& target : input_ids_target_inputs) { | ||
| target.replace_source_output(processed_input_ids); | ||
| } | ||
| } else if (input_ids_node->get_friendly_name() == "inputs_embeds") { |
There was a problem hiding this comment.
could you add a new unit test for this scenario?
There was a problem hiding this comment.
Yes, of course, I'm working on it rn
There was a problem hiding this comment.
Created a test for the "inputs_embeds" input based on the nanoLLaVA pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VLMs have tokens and their generation already served as the "inputs_embeds" input, so there's no need to transform the input in the way this is done for "input_ids".
Tickets:
Signed-off-by: Andrii Staikov andrii.staikov@intel.com