Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MO|nGraph]GatherND_8 #7743

Merged
merged 50 commits into from
Nov 10, 2021
Merged

[MO|nGraph]GatherND_8 #7743

merged 50 commits into from
Nov 10, 2021

Conversation

achetver
Copy link
Contributor

@achetver achetver commented Sep 29, 2021 •
edited
Loading

MO + nGraph shell implementation for GatherND_8 operation

Ticket: 66647, 66650

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names

Validation:

  • Unit tests: Updated;
  • Framework operation tests: Will be done in 68623;
  • Transformation tests: N/A - No new implemented transformations;
  • Model Optimizer IR Reader check: Done.

Documentation:

  • Supported frameworks operations list: Added restriction for negative indices;
  • Supported public models list: N/A - Nothing to add;
  • User guide update: N/A - Nothing to update.

@achetver achetver changed the title [MO]GatherND [MO]GatherND_8 Sep 29, 2021
@achetver achetver changed the title [MO]GatherND_8 [MO|nGraph]GatherND_8 Oct 5, 2021
@achetver achetver added category: MO Model Optimizer category: Core OpenVINO Core (aka ngraph) labels Oct 11, 2021
@achetver achetver added this to the 2022.1 milestone Oct 11, 2021
@achetver achetver requested review from a team, mvafin, sadolini and yekruglov and removed request for a team October 12, 2021 10:42
pavel-esir
pavel-esir approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@pavel-esir pavel-esir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

ngraph/core/include/openvino/op/util/gather_nd_base.hpp Show resolved Hide resolved
ngraph/core/src/op/util/gather_nd_base.cpp Outdated Show resolved Hide resolved
ngraph/core/src/op/util/gather_nd_base.cpp Outdated Show resolved Hide resolved
@achetver
Copy link
Contributor Author

@ilyachur @GlebKazantaev Guys, please take a look at nGraph part.

@a-sidorova a-sidorova mentioned this pull request Oct 29, 2021
Closed
This was referenced Nov 1, 2021
Merged
Merged
@evgenytalanin-intel evgenytalanin-intel merged commit c8e1c8e into openvinotoolkit:master Nov 10, 2021
openvino-dev-samples pushed a commit to openvino-dev-samples/openvino that referenced this pull request Nov 23, 2021
@openvino-dev-samples
[MO|nGraph]GatherND_8 (openvinotoolkit#7743)
7f5c752 
* Add GatherND_8 operation

* Update shape infer function and tests

* Initial commit for nGraph GatherND_8 operation

* Add GatherNDBase class implementation

* Fix base class errors

* Add missrd header

* Update base class

* Update GatherND_8 implementation

* Fix codestyle

* Fix wrong rank

* Implement tests for gatherND_8 shape inference function

* fix codestyle

* Add limitation to doc

* Siplyfy check in shape inference

* Add more test cases

* Update shape inference function

* Add more test cases to cover all case with dynamic input shapes

* Update shape inference function

* Refactor tests

* Add visitor tests for gatherND_8 operation

* Correct comment

* Add additional check is shape inference function

* Update shape inference implementation for gathernd operartion

* Fix codestyle

* Remove restriction for data is fully defined

* Update shape inference functon

* Fix missed check for nonetype

* Remove redundant checks for batch_dims

* Fix codestyle
openvino-dev-samples pushed a commit to openvino-dev-samples/openvino that referenced this pull request Nov 24, 2021
@openvino-dev-samples
[MO|nGraph]GatherND_8 (openvinotoolkit#7743)
b977c5b 
* Add GatherND_8 operation

* Update shape infer function and tests

* Initial commit for nGraph GatherND_8 operation

* Add GatherNDBase class implementation

* Fix base class errors

* Add missrd header

* Update base class

* Update GatherND_8 implementation

* Fix codestyle

* Fix wrong rank

* Implement tests for gatherND_8 shape inference function

* fix codestyle

* Add limitation to doc

* Siplyfy check in shape inference

* Add more test cases

* Update shape inference function

* Add more test cases to cover all case with dynamic input shapes

* Update shape inference function

* Refactor tests

* Add visitor tests for gatherND_8 operation

* Correct comment

* Add additional check is shape inference function

* Update shape inference implementation for gathernd operartion

* Fix codestyle

* Remove restriction for data is fully defined

* Update shape inference functon

* Fix missed check for nonetype

* Remove redundant checks for batch_dims

* Fix codestyle
@jgespino jgespino mentioned this pull request Jan 4, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadolini sadolini sadolini approved these changes

@yekruglov yekruglov yekruglov approved these changes

@rkazants rkazants rkazants approved these changes

@pavel-esir pavel-esir pavel-esir approved these changes

@ilyachur ilyachur ilyachur approved these changes

@andrew-zaytsev andrew-zaytsev Awaiting requested review from andrew-zaytsev andrew-zaytsev is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

@GlebKazantaev GlebKazantaev Awaiting requested review from GlebKazantaev

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: MO Model Optimizer
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
7 participants
@achetver @rkazants @ilyachur @pavel-esir @sadolini @yekruglov @evgenytalanin-intel