Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten parameter objects #16

Merged

Conversation

negvet
Copy link
Collaborator

@negvet negvet commented Jun 13, 2024

XXXXParameters data class -> Method parameters

This simplifies the user experience.

Rearrange explainer methods

Align Visualizer with Explainer

Make Visualizer stateless

@goodsong81 goodsong81 changed the base branch from develop to releases/1.0.0 June 14, 2024 02:47
goodsong81
goodsong81 previously approved these changes Jun 14, 2024
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In overall LGTM.
Left a few suggestions, though.

openvino_xai/explainer/mode.py Outdated Show resolved Hide resolved
openvino_xai/explainer/explainer.py Show resolved Hide resolved
openvino_xai/explainer/visualizer.py Outdated Show resolved Hide resolved
openvino_xai/methods/factory.py Outdated Show resolved Hide resolved
Copy link
Contributor

@GalyaZalesskaya GalyaZalesskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great update

@negvet negvet dismissed stale reviews from GalyaZalesskaya and goodsong81 via d830a60 June 14, 2024 14:12
@negvet negvet merged commit 160fdfa into openvinotoolkit:releases/1.0.0 Jun 14, 2024
4 checks passed
@goodsong81 goodsong81 added this to the 1.0.0 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants