Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for deep dive notebook #35

Conversation

GalyaZalesskaya
Copy link
Contributor

  • Fix resize failing for targets=All classes. Failed during resizing the tensor with 1001 channels, so I changed code to resize separately per-channel.
  • Update black-box to process (batch, height, width, channel) model layout together with (batch, channel, height, width)

goodsong81
goodsong81 previously approved these changes Jul 3, 2024
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

openvino_xai/methods/black_box/rise.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@negvet negvet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, please check my comments.

openvino_xai/explainer/visualizer.py Outdated Show resolved Hide resolved
openvino_xai/methods/black_box/rise.py Outdated Show resolved Hide resolved
@negvet
Copy link
Collaborator

negvet commented Jul 4, 2024

Please add unit tests

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (releases/1.0.0@e2cd66f). Learn more about missing BASE report.

Files Patch % Lines
openvino_xai/methods/black_box/rise.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             releases/1.0.0      #35   +/-   ##
=================================================
  Coverage                  ?   90.89%           
=================================================
  Files                     ?       18           
  Lines                     ?     1076           
  Branches                  ?        0           
=================================================
  Hits                      ?      978           
  Misses                    ?       98           
  Partials                  ?        0           
Flag Coverage Δ
dev-py310 90.79% <94.73%> (?)
dev-py311 90.70% <94.73%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@negvet negvet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goodsong81 goodsong81 merged commit 240c929 into openvinotoolkit:releases/1.0.0 Jul 5, 2024
4 checks passed
@goodsong81 goodsong81 added this to the 1.0.0 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants