Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Anomaly Task] Fix non deterministic + sample.py #1118

Merged
merged 3 commits into from
May 31, 2022
Merged

[Anomaly Task] Fix non deterministic + sample.py #1118

merged 3 commits into from
May 31, 2022

Conversation

ashwinvaidya17
Copy link
Contributor

@ashwinvaidya17 ashwinvaidya17 commented May 23, 2022 •
edited
Loading

Changes

  • Fix doc string in sample.py
  • Add seed to train task. The only issue here is that I am not sure how the tests are run. They might not use seed. This is also the second issue. It changes the function signature which might not be a good idea.
  • I've added a small readme to tools folder regarding sample.py. I feel these two commands are enough but let me know if you need anything else.

Tests

🏃‍♂️ https://ci-ote.iotg.sclab.intel.com/job/ote/job/ote-test/1820/

@ashwinvaidya17 ashwinvaidya17 added the ALGO Any changes in OTX Algo Tasks implementation label May 23, 2022
@ashwinvaidya17 ashwinvaidya17 requested a review from a team as a code owner May 23, 2022 13:43
samet-akcay
samet-akcay reviewed May 23, 2022
View reviewed changes
external/anomaly/tools/README.md Outdated
Comment on lines 14 to 15
python tools/sample.py --dataset_path ~/datasets/MVTec --category bottle --train-ann-files ../../data/MVtec/bottle/segmentation/train.json --val-ann-files ../../data/MVtec/bottle/segmentation/val.json --test-ann-files ../../data/MVtec/bottle/segmentation/test.json --model_template_path ./configs/anomaly_segmentation/padim/template.yaml
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split the line here

python tools/sample.py \
    --dataset_path ~/datasets/MVTec \
    --category bottle \
    --train-ann-files ../../data/MVtec/bottle/segmentation/train.json \
    --val-ann-files ../../data/MVtec/bottle/segmentation/val.json \
    --test-ann-files ../../data/MVtec/bottle/segmentation/test.json \
    --model_template_path ./configs/anomaly_segmentation/padim/template.yaml

samet-akcay
samet-akcay reviewed May 23, 2022
View reviewed changes
external/anomaly/tools/sample.py Outdated
@@ -61,13 +61,18 @@ def __init__(
val_subset: Dict[str, str],
test_subset: Dict[str, str],
model_template_path: str,
seed: Optional[int] = 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the variable Optional, shouldn't it be set to None?

samet-akcay
samet-akcay reviewed May 23, 2022
View reviewed changes
external/anomaly/ote_anomalib/train_task.py Outdated
@@ -36,17 +38,26 @@ def train(
dataset: DatasetEntity,
output_model: ModelEntity,
train_parameters: TrainParameters,
seed: Optional[int] = 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the variable Optional, shouldn't it be set to None?

samet-akcay
samet-akcay requested changes May 23, 2022
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR, only minor comments

@ashwinvaidya17
Copy link
Contributor Author

Anomaly tests have passed but looks like deep-object-reid and mmsegmentation tests are failing

goodsong81
goodsong81 approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goodsong81 goodsong81 merged commit 56e6624 into develop May 31, 2022
@goodsong81 goodsong81 deleted the ashwin/fix_non_deterministic branch May 31, 2022 06:46
@ashwinvaidya17 ashwinvaidya17 mentioned this pull request May 31, 2022
Closed
sstrehlk added a commit that referenced this pull request May 31, 2022
@sstrehlk
Squashed commit of the following:
474317e 
commit 02d724a
Merge: 56e6624 3ba3272
Author: Songki Choi <songki.choi@intel.com>
Date:   Tue May 31 16:00:39 2022 +0900

    Merge pull request #1113 from openvinotoolkit/da/anomaly-exportable-code-fix

    [ANOMALY] Fix: exportable code for anomaly tasks

commit 56e6624
Merge: 2e18117 9ef77d0
Author: Songki Choi <songki.choi@intel.com>
Date:   Tue May 31 15:45:59 2022 +0900

    Merge pull request #1118 from openvinotoolkit/ashwin/fix_non_deterministic

    [Anomaly Task] Fix non deterministic + sample.py

commit 2e18117
Merge: c240c4b 16f2138
Author: Songki Choi <songki.choi@intel.com>
Date:   Tue May 31 15:40:43 2022 +0900

    Merge pull request #1120 from openvinotoolkit/da/use-is-anomalous

    [ANOMALY] Use is_anomalous attribute instead of string matching

commit c240c4b
Merge: f003a20 46bf1bc
Author: Songki Choi <songki.choi@intel.com>
Date:   Tue May 31 15:33:42 2022 +0900

    Merge pull request #1117 from wonjuleee/develop

    nncf versionn upgrade

commit 16f2138
Author: Dick Ameln <dick.ameln@intel.com>
Date:   Mon May 30 11:35:18 2022 +0200

    add is_anomalous attribute to labels in test cases

commit f003a20
Merge: 38a4d88 bdb7599
Author: Songki Choi <songki.choi@intel.com>
Date:   Wed May 25 15:39:02 2022 +0900

    Merge pull request #1112 from openvinotoolkit/vsaltykovx/add_mmdetection_input_parameters_validation_2

    Vsaltykovx/add mmdetection input parameters validation 2

commit 2aab8df
Author: Dick Ameln <dick.ameln@intel.com>
Date:   Tue May 24 17:56:52 2022 +0200

    use is_anomalous attribute instead of string matching

commit bdb7599
Author: Slawomir Strehlke <slawomir.strehlke@intel.com>
Date:   Tue May 24 10:21:37 2022 +0200

    Corrected config input parameter type.

commit 9ef77d0
Author: Ashwin Vaidya <ashwin.vaidya@intel.com>
Date:   Mon May 23 16:01:37 2022 +0200

    Set optional params to None

commit fdd5307
Author: Ashwin Vaidya <ashwin.vaidya@intel.com>
Date:   Mon May 23 15:39:37 2022 +0200

    spacing

commit b7c30a2
Author: Ashwin Vaidya <ashwin.vaidya@intel.com>
Date:   Mon May 23 15:38:59 2022 +0200

    Add seed + sample.py guide

commit 46bf1bc
Author: Wonju Lee <wonju.lee@intel.com>
Date:   Mon May 23 19:10:47 2022 +0900

    nncf versionn upgrade

commit 38a4d88
Merge: c49a6fd cf33dcb
Author: Songki Choi <songki.choi@intel.com>
Date:   Mon May 23 18:20:43 2022 +0900

    Merge pull request #1114 from A-Artemis/develop

    Added a getter and a setter for __metadata

commit cf33dcb
Author: Aurelien <aurelien.adriaenssens@intel.com>
Date:   Mon May 23 10:20:33 2022 +0200

    Corrected the usage of .metadata or .get_metadata() in certain tests. In test_metadata.py I have updated the assertion to "typing.Optional[str]".

commit fcf4925
Author: Aurelien <aurelien.adriaenssens@intel.com>
Date:   Thu May 19 16:42:18 2022 +0200

    Added a getter and a setter for __metadata of DatasetItemEntity. Updated the tests as well.

commit 3ba3272
Author: Dick Ameln <dick.ameln@intel.com>
Date:   Wed May 18 17:08:17 2022 +0200

    use standard visualizer instead of anomaly visualizer for anomaly tasks

commit 95440ea
Merge: 808a0ed c49a6fd
Author: hlewando <Killer_21212>
Date:   Wed May 18 13:10:30 2022 +0200

    Merge remote-tracking branch 'origin/develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 808a0ed
Merge: 3ac55ba c54250b
Author: Hubert Lewandowski <hubert.lewandowski@intel.com>
Date:   Tue May 17 08:56:58 2022 +0200

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 3ac55ba
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Apr 5 13:58:01 2022 +0300

    updated check_input_parameters_type

commit c99aebd
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Apr 5 13:46:33 2022 +0300

    added tests to cover get_data_cfg function and StopLossNanTrainingHook after_train_iter method

commit 6a7df1c
Merge: 31e179c 33d11e6
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Apr 5 13:02:21 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

    # Conflicts:
    #	external/mmdetection/detection_tasks/apis/detection/openvino_task.py

commit 31e179c
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Mar 28 10:21:05 2022 +0300

    updated check_nested_classes_parameters function

commit cd31623
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Mar 25 13:44:21 2022 +0300

    fixed expected type in JsonFilePathCheck

commit fb0fd0e
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Mar 25 13:34:10 2022 +0300

    updated function in ote_sdk/ote_sdk/utils/argument_checks.py

commit ede7332
Merge: cc77164 0d4ce2c
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Mar 25 11:55:08 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit cc77164
Merge: 94c496a 4129bc4
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Wed Mar 23 10:01:59 2022 +0300

    Merge remote-tracking branch 'origin/vsaltykovx/add_mmdetection_input_parameters_validation' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 94c496a
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Wed Mar 23 10:01:36 2022 +0300

    optimized imports

commit 4129bc4
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Mar 22 17:15:12 2022 +0300

    fix type for weight_file

commit 4f55cae
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Mar 22 15:11:00 2022 +0300

    updated expected types

commit 3e33ba6
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Mar 22 14:09:50 2022 +0300

    added input parameters validation in mmdet/apis/ote/apis/detection/ methods and functions

commit 8735fbb
Merge: 3783f50 1833b6c
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Mar 22 11:19:24 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 3783f50
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Mar 21 17:07:23 2022 +0300

    fixed test_load_annotation_from_ote_dataset_call_params_validation

commit 5ba02cc
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Mar 21 16:16:05 2022 +0300

    moved mmdetection params validation tests to training_extensions

commit b5f6621
Merge: e26fd37 8d3e4ab
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Mar 21 16:07:11 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit e26fd37
Merge: 04e5fb8 5931ec7
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Mar 21 16:05:36 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 04e5fb8
Merge: 1d5e06c abafaa3
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Mar 18 13:55:12 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 1d5e06c
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Mar 18 12:07:27 2022 +0300

    added check_input_parameters_type decorator

commit 6919ef8
Merge: ef9ffce a4b4263
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Wed Mar 16 11:55:58 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit ef9ffce
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Mar 1 09:03:26 2022 +0300

    removed additional log messages

commit 3fb9680
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Feb 28 17:05:51 2022 +0300

    updated logger

commit 52fd656
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Feb 28 13:19:52 2022 +0300

    added log messages to raise_value_error_if_parameter_has_unexpected_type

commit eb83c34
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Feb 28 13:18:40 2022 +0300

    added log messages to raise_value_error_if_parameter_has_unexpected_type

commit 7071e87
Merge: 30fbec2 a2ae0e0
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Feb 28 11:12:09 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 30fbec2
Merge: ab81a36 6b3302e
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Feb 25 18:24:51 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit ab81a36
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Feb 25 17:24:05 2022 +0300

    moved load_test_dataset function to tests\parameters_validation\validation_helper.py

commit 51c0a38
Merge: d1c521c 719e80a
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Thu Feb 24 09:17:49 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit d1c521c
Merge: adc9621 c1c3753
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Feb 22 09:16:13 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit adc9621
Merge: 23207fd e8d24d0
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Feb 21 09:17:14 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 23207fd
Merge: 1cc4410 70bd630
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Feb 21 08:19:36 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 1cc4410
Merge: 44a6c2b 9d2503b
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Feb 18 15:08:41 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 44a6c2b
Merge: 5a34e7f d99df37
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Feb 18 09:04:48 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 5a34e7f
Merge: af5b029 533ba44
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Thu Feb 17 13:05:52 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit af5b029
Merge: f9d96a7 3ebf8e9
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Thu Feb 17 09:00:44 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit f9d96a7
Merge: 0b8cbf1 461d501
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Feb 15 16:56:36 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 0b8cbf1
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Feb 15 15:20:17 2022 +0300

    added input parameters validation and tests for mmdet/apis/ote
sstrehlk added a commit that referenced this pull request Jun 3, 2022
@sstrehlk
Squashed commit of the following:
3460937 
commit f5d8097
Merge: cc11743 561daf0
Author: Songki Choi <songki.choi@intel.com>
Date:   Fri Jun 3 13:43:02 2022 +0900

    Merge pull request #1122 from openvinotoolkit/CVS-85318-nncf_precision

    CVS-85318 nncf precision

commit cc11743
Merge: 94fcade 082b963
Author: Songki Choi <songki.choi@intel.com>
Date:   Fri Jun 3 13:27:00 2022 +0900

    Merge pull request #1044 from openvinotoolkit/ad/mmseg_mmdet_updates

    Add nncf configs for segmentation models

commit 561daf0
Author: Wonju Lee <wonju.lee@intel.com>
Date:   Thu Jun 2 22:38:53 2022 +0900

    fix precision for onnly pruning

commit e9e58f9
Author: Wonju Lee <wonju.lee@intel.com>
Date:   Thu Jun 2 22:34:27 2022 +0900

    add nncf precision test

commit 0957213
Author: Wonju Lee <wonju.lee@intel.com>
Date:   Thu Jun 2 22:32:39 2022 +0900

    fix nncf precision config to exported model

commit 94fcade
Merge: a4f35cb d28d531
Author: Songki Choi <songki.choi@intel.com>
Date:   Thu Jun 2 18:18:59 2022 +0900

    Merge pull request #1123 from openvinotoolkit/es/protobuf_constraint

    add protobuf constraint

commit a4f35cb
Merge: eed9902 073d045
Author: Songki Choi <songki.choi@intel.com>
Date:   Thu Jun 2 15:36:50 2022 +0900

    Merge pull request #1099 from openvinotoolkit/sangdaen/hpo_anomaly_progress

    [HPO] Enabling ote_anomalib report score for hpopt

commit eed9902
Author: Slawomir Strehlke <slawomir.strehlke@intel.com>
Date:   Wed Jun 1 14:06:23 2022 +0200

    restored previous nnc dependecy revision.

commit b1cb1d9
Author: Slawomir Strehlke <slawomir.strehlke@intel.com>
Date:   Wed Jun 1 13:24:50 2022 +0200

    removed nncf==2.2.0 requirement from external/mmsegmentation/requirements.txt (dependency conflict)

commit d28d531
Author: eunwoosh <eunwoo.shin@intel.com>
Date:   Tue May 31 18:38:19 2022 +0900

    add protobuf constraint

commit 02d724a
Merge: 56e6624 3ba3272
Author: Songki Choi <songki.choi@intel.com>
Date:   Tue May 31 16:00:39 2022 +0900

    Merge pull request #1113 from openvinotoolkit/da/anomaly-exportable-code-fix

    [ANOMALY] Fix: exportable code for anomaly tasks

commit 56e6624
Merge: 2e18117 9ef77d0
Author: Songki Choi <songki.choi@intel.com>
Date:   Tue May 31 15:45:59 2022 +0900

    Merge pull request #1118 from openvinotoolkit/ashwin/fix_non_deterministic

    [Anomaly Task] Fix non deterministic + sample.py

commit 2e18117
Merge: c240c4b 16f2138
Author: Songki Choi <songki.choi@intel.com>
Date:   Tue May 31 15:40:43 2022 +0900

    Merge pull request #1120 from openvinotoolkit/da/use-is-anomalous

    [ANOMALY] Use is_anomalous attribute instead of string matching

commit c240c4b
Merge: f003a20 46bf1bc
Author: Songki Choi <songki.choi@intel.com>
Date:   Tue May 31 15:33:42 2022 +0900

    Merge pull request #1117 from wonjuleee/develop

    nncf versionn upgrade

commit 073d045
Author: eunwoosh <eunwoo.shin@intel.com>
Date:   Thu May 19 13:05:39 2022 +0900

    change train_end to valdiation_end

commit 4fe2598
Author: eunwoosh <eunwoo.shin@intel.com>
Date:   Wed May 18 12:00:35 2022 +0900

    make new callback function

commit 4ea9d44
Author: eunwoosh <eunwoo.shin@intel.com>
Date:   Tue May 17 13:14:09 2022 +0900

    modify hpo reporting place from on_validation_epoch_end to on_train_epoch_end

commit 184df04
Author: SangdaeNam <sangdae.nam@intel.com>
Date:   Thu May 12 00:40:42 2022 +0900

    20220511 metric change 2

commit 3bac4de
Author: SangdaeNam <sangdae.nam@intel.com>
Date:   Thu May 12 00:30:14 2022 +0900

    20220511 metric change

commit ad032dd
Author: SangdaeNam <sangdae.nam@intel.com>
Date:   Thu May 12 00:02:14 2022 +0900

    [HPO] Enabling ote_anomalib to report score for hpopt

commit 16f2138
Author: Dick Ameln <dick.ameln@intel.com>
Date:   Mon May 30 11:35:18 2022 +0200

    add is_anomalous attribute to labels in test cases

commit 082b963
Author: sooahleex <sooah.lee@intel.com>
Date:   Thu May 26 01:48:20 2022 +0900

    update mmseg submodule

commit f003a20
Merge: 38a4d88 bdb7599
Author: Songki Choi <songki.choi@intel.com>
Date:   Wed May 25 15:39:02 2022 +0900

    Merge pull request #1112 from openvinotoolkit/vsaltykovx/add_mmdetection_input_parameters_validation_2

    Vsaltykovx/add mmdetection input parameters validation 2

commit 2aab8df
Author: Dick Ameln <dick.ameln@intel.com>
Date:   Tue May 24 17:56:52 2022 +0200

    use is_anomalous attribute instead of string matching

commit bdb7599
Author: Slawomir Strehlke <slawomir.strehlke@intel.com>
Date:   Tue May 24 10:21:37 2022 +0200

    Corrected config input parameter type.

commit 9ef77d0
Author: Ashwin Vaidya <ashwin.vaidya@intel.com>
Date:   Mon May 23 16:01:37 2022 +0200

    Set optional params to None

commit fdd5307
Author: Ashwin Vaidya <ashwin.vaidya@intel.com>
Date:   Mon May 23 15:39:37 2022 +0200

    spacing

commit b7c30a2
Author: Ashwin Vaidya <ashwin.vaidya@intel.com>
Date:   Mon May 23 15:38:59 2022 +0200

    Add seed + sample.py guide

commit 46bf1bc
Author: Wonju Lee <wonju.lee@intel.com>
Date:   Mon May 23 19:10:47 2022 +0900

    nncf versionn upgrade

commit 38a4d88
Merge: c49a6fd cf33dcb
Author: Songki Choi <songki.choi@intel.com>
Date:   Mon May 23 18:20:43 2022 +0900

    Merge pull request #1114 from A-Artemis/develop

    Added a getter and a setter for __metadata

commit cf33dcb
Author: Aurelien <aurelien.adriaenssens@intel.com>
Date:   Mon May 23 10:20:33 2022 +0200

    Corrected the usage of .metadata or .get_metadata() in certain tests. In test_metadata.py I have updated the assertion to "typing.Optional[str]".

commit 13d29b0
Author: JihwanEom <jihwan.eom@intel.com>
Date:   Mon May 23 13:20:39 2022 +0900

    Update mmseg commit

commit a43802f
Merge: 92268af f408698
Author: sooahleex <sooah.lee@intel.com>
Date:   Fri May 20 01:31:04 2022 +0900

    Merge branch 'releases/v0.2.0-sc1.1' of https://github.com/openvinotoolkit/training_extensions into ad/mmseg_mmdet_updates

commit fcf4925
Author: Aurelien <aurelien.adriaenssens@intel.com>
Date:   Thu May 19 16:42:18 2022 +0200

    Added a getter and a setter for __metadata of DatasetItemEntity. Updated the tests as well.

commit 3ba3272
Author: Dick Ameln <dick.ameln@intel.com>
Date:   Wed May 18 17:08:17 2022 +0200

    use standard visualizer instead of anomaly visualizer for anomaly tasks

commit 95440ea
Merge: 808a0ed c49a6fd
Author: hlewando <Killer_21212>
Date:   Wed May 18 13:10:30 2022 +0200

    Merge remote-tracking branch 'origin/develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit f408698
Merge: 116fcc0 f2c8525
Author: Songki Choi <songki.choi@intel.com>
Date:   Tue May 17 16:32:16 2022 +0900

    Merge pull request #1104 from openvinotoolkit/albert/release/annotation-fix

    [OTE_SDK] Append label to dataset item fix

commit f2c8525
Author: AlbertvanHouten <albert.van.houten@intel.com>
Date:   Tue May 17 09:17:18 2022 +0200

    revert subset test update

commit 808a0ed
Merge: 3ac55ba c54250b
Author: Hubert Lewandowski <hubert.lewandowski@intel.com>
Date:   Tue May 17 08:56:58 2022 +0200

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 116fcc0
Merge: fa03d14 496cd9b
Author: Songki Choi <songki.choi@intel.com>
Date:   Mon May 16 10:21:27 2022 +0900

    Merge pull request #1106 from openvinotoolkit/eugene/remove_dist_build

    remove dist/build

commit 496cd9b
Author: Eugene Liu <eugene.liu@intel.com>
Date:   Fri May 13 15:00:19 2022 +0100

    remove dist/build

commit 6e534c6
Author: AlbertvanHouten <albert.van.houten@intel.com>
Date:   Thu May 12 09:52:05 2022 +0200

    compare shape instead of annotation for appending labels

commit 9e916f1
Author: AlbertvanHouten <albert.van.houten@intel.com>
Date:   Thu May 12 09:48:12 2022 +0200

    reverted removing id from annotation.py

commit 2286e21
Author: AlbertvanHouten <albert.van.houten@intel.com>
Date:   Thu May 12 09:21:13 2022 +0200

    Addressed typing in shape/dataset/annotation

commit 981dea2
Author: AlbertvanHouten <albert.van.houten@intel.com>
Date:   Wed May 11 13:34:46 2022 +0200

    Removed labels from shape and id from annotation

commit 92268af
Author: Eugene Liu <eugene.liu@intel.com>
Date:   Mon Apr 25 11:34:49 2022 +0100

    update mmdetection branch

commit 3ac55ba
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Apr 5 13:58:01 2022 +0300

    updated check_input_parameters_type

commit c99aebd
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Apr 5 13:46:33 2022 +0300

    added tests to cover get_data_cfg function and StopLossNanTrainingHook after_train_iter method

commit 6a7df1c
Merge: 31e179c 33d11e6
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Apr 5 13:02:21 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

    # Conflicts:
    #	external/mmdetection/detection_tasks/apis/detection/openvino_task.py

commit 56f1b09
Author: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Date:   Mon Apr 4 17:51:39 2022 +0300

    Update mmdet

commit 0d1fef4
Author: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Date:   Mon Apr 4 17:48:27 2022 +0300

    Add nncf configs and update mmseg

commit 31e179c
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Mar 28 10:21:05 2022 +0300

    updated check_nested_classes_parameters function

commit cd31623
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Mar 25 13:44:21 2022 +0300

    fixed expected type in JsonFilePathCheck

commit fb0fd0e
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Mar 25 13:34:10 2022 +0300

    updated function in ote_sdk/ote_sdk/utils/argument_checks.py

commit ede7332
Merge: cc77164 0d4ce2c
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Mar 25 11:55:08 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit cc77164
Merge: 94c496a 4129bc4
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Wed Mar 23 10:01:59 2022 +0300

    Merge remote-tracking branch 'origin/vsaltykovx/add_mmdetection_input_parameters_validation' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 94c496a
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Wed Mar 23 10:01:36 2022 +0300

    optimized imports

commit 4129bc4
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Mar 22 17:15:12 2022 +0300

    fix type for weight_file

commit 4f55cae
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Mar 22 15:11:00 2022 +0300

    updated expected types

commit 3e33ba6
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Mar 22 14:09:50 2022 +0300

    added input parameters validation in mmdet/apis/ote/apis/detection/ methods and functions

commit 8735fbb
Merge: 3783f50 1833b6c
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Mar 22 11:19:24 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 3783f50
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Mar 21 17:07:23 2022 +0300

    fixed test_load_annotation_from_ote_dataset_call_params_validation

commit 5ba02cc
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Mar 21 16:16:05 2022 +0300

    moved mmdetection params validation tests to training_extensions

commit b5f6621
Merge: e26fd37 8d3e4ab
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Mar 21 16:07:11 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit e26fd37
Merge: 04e5fb8 5931ec7
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Mar 21 16:05:36 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 04e5fb8
Merge: 1d5e06c abafaa3
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Mar 18 13:55:12 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 1d5e06c
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Mar 18 12:07:27 2022 +0300

    added check_input_parameters_type decorator

commit 6919ef8
Merge: ef9ffce a4b4263
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Wed Mar 16 11:55:58 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit ef9ffce
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Mar 1 09:03:26 2022 +0300

    removed additional log messages

commit 3fb9680
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Feb 28 17:05:51 2022 +0300

    updated logger

commit 52fd656
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Feb 28 13:19:52 2022 +0300

    added log messages to raise_value_error_if_parameter_has_unexpected_type

commit eb83c34
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Feb 28 13:18:40 2022 +0300

    added log messages to raise_value_error_if_parameter_has_unexpected_type

commit 7071e87
Merge: 30fbec2 a2ae0e0
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Feb 28 11:12:09 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 30fbec2
Merge: ab81a36 6b3302e
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Feb 25 18:24:51 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit ab81a36
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Feb 25 17:24:05 2022 +0300

    moved load_test_dataset function to tests\parameters_validation\validation_helper.py

commit 51c0a38
Merge: d1c521c 719e80a
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Thu Feb 24 09:17:49 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit d1c521c
Merge: adc9621 c1c3753
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Feb 22 09:16:13 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit adc9621
Merge: 23207fd e8d24d0
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Feb 21 09:17:14 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 23207fd
Merge: 1cc4410 70bd630
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Mon Feb 21 08:19:36 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 1cc4410
Merge: 44a6c2b 9d2503b
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Feb 18 15:08:41 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 44a6c2b
Merge: 5a34e7f d99df37
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Fri Feb 18 09:04:48 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 5a34e7f
Merge: af5b029 533ba44
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Thu Feb 17 13:05:52 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit af5b029
Merge: f9d96a7 3ebf8e9
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Thu Feb 17 09:00:44 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit f9d96a7
Merge: 0b8cbf1 461d501
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Feb 15 16:56:36 2022 +0300

    Merge branch 'develop' into vsaltykovx/add_mmdetection_input_parameters_validation

commit 0b8cbf1
Author: saltykox <valeriyx.saltykov@intel.com>
Date:   Tue Feb 15 15:20:17 2022 +0300

    added input parameters validation and tests for mmdet/apis/ote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay requested changes

@goodsong81 goodsong81 goodsong81 approved these changes

@djdameln djdameln Awaiting requested review from djdameln djdameln is a code owner

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashwinvaidya17 @goodsong81 @samet-akcay