Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix saliency map issues #1232

Merged
merged 6 commits into from
Sep 1, 2022
Merged

Fix saliency map issues #1232

merged 6 commits into from
Sep 1, 2022

Conversation

eugene123tw
Copy link
Contributor

@eugene123tw eugene123tw commented Aug 26, 2022 •
edited
Loading

@eugene123tw eugene123tw requested a review from a team as a code owner August 26, 2022 15:27
@eugene123tw
Copy link
Contributor Author

run ote-test

@github-actions github-actions bot added API Any changes in OTX API ALGO Any changes in OTX Algo Tasks implementation labels Aug 26, 2022
harimkang
harimkang previously approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an issue that didn't work because the type and name of ResultMediaEntity were changed?

harimkang
harimkang suggested changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I'll look at the submodules first, and I'll approve it again after the commit of the submodules are merged and changed.

@eugene123tw eugene123tw requested a review from harimkang August 31, 2022 07:39
harimkang
harimkang previously approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that there is still a conflict on the submodule side.

@eugene123tw eugene123tw requested a review from harimkang August 31, 2022 08:56
harimkang
harimkang previously approved these changes Aug 31, 2022
View reviewed changes
goodsong81
goodsong81 approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chuneuny-emily chuneuny-emily merged commit 86e9e4a into releases/v0.3.0-sc1.2 Sep 1, 2022
@chuneuny-emily chuneuny-emily deleted the eugene/CVS-90192-fix-saliency-map branch September 1, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuneuny-emily chuneuny-emily chuneuny-emily approved these changes

@goodsong81 goodsong81 goodsong81 approved these changes

@harimkang harimkang Awaiting requested review from harimkang

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eugene123tw @goodsong81 @harimkang @chuneuny-emily