Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTX] Rebase latest changes for MPA merge #1468

Merged
merged 27 commits into from
Dec 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
867a239
make logfile saved in save-model-to directory
eunwoosh Oct 25, 2022
94fbfa5
enable train
eunwoosh Nov 1, 2022
2ea48e1
make main process train also
eunwoosh Nov 4, 2022
d07e116
bugfix
eunwoosh Nov 11, 2022
78511fa
refactor multi gpu training
eunwoosh Nov 25, 2022
562621d
make all processs have same output path
eunwoosh Nov 25, 2022
72805e3
prevent child process from being termated by fokred main process
eunwoosh Dec 6, 2022
67fe228
refactor multigpu implementation
eunwoosh Dec 12, 2022
c1d913a
refactor multi gpu implementation
eunwoosh Dec 13, 2022
6b26786
modify argument help sentence
eunwoosh Dec 13, 2022
fb4bac5
add multi gpu test code
eunwoosh Dec 13, 2022
35e0814
align with pre-commit test
eunwoosh Dec 15, 2022
acd54b9
separate multi GPU manager class
eunwoosh Dec 15, 2022
ce7acf6
modify train cli argument 'save-logs-to' to 'output-path'
eunwoosh Dec 16, 2022
3e4b6e2
remove tray excpet during killing child process
eunwoosh Dec 16, 2022
5ca59dd
apply output_path to all tasks
eunwoosh Dec 16, 2022
6d1445a
change print to logger
eunwoosh Dec 16, 2022
497ae13
skip multi gpu test if number of gpu is insufficient
eunwoosh Dec 20, 2022
428c524
fix typo
eunwoosh Dec 21, 2022
5587d32
multi gpu test bugfix
eunwoosh Dec 22, 2022
a202a30
isort fix
eunwoosh Dec 26, 2022
58b4028
test case bugfix
eunwoosh Dec 26, 2022
a4fa37c
fix typo and change some variable name
eunwoosh Dec 28, 2022
a31c064
Merge pull request #1392 from openvinotoolkit/multigpu_enablement
eunwoosh Dec 28, 2022
138bf73
[OTX] Apply changes in develop to feature/otx branch (#1436)
goodsong81 Dec 28, 2022
3eb437d
Merge remote-tracking branch 'origin/feature/otx' into songkich/otx-m…
goodsong81 Dec 28, 2022
d1542c5
Apply latest MPA https://github.com/openvinotoolkit/model_preparation…
goodsong81 Dec 28, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@ __pycache__
.vscode/
*.iml

venv
*venv*/
env
otx-workspace*
.env
.tox
results/

data/*
.coverage
Expand Down
82 changes: 10 additions & 72 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,6 @@ repos:
files: '^(otx|tests)/.*\.py'
exclude: "tests/ote_cli"

# NOTE: ote-sdk and ote-cli will be deprecated. The following config
# is to be removed.
- id: isort
alias: isort_ote_sdk
name: "isort - legacy (ote_sdk)"
files: '^ote_sdk/.*\.py'
- id: isort
alias: isort_rest
name: "isort (ote_cli|external)"
files: '^(ote_cli|external/anomaly|external/model-preparation-algorithm)/.*\.py'
exclude: "tests/"

- repo: https://github.com/psf/black
rev: 22.6.0
hooks:
Expand All @@ -31,32 +19,21 @@ repos:
files: '^(otx|tests)/.*\.py'
exclude: "tests/ote_cli"

# NOTE: ote-sdk and ote-cli will be deprecated. The following config
# is to be removed.
- id: black
name: "black - legacy (ote_sdk|ote_cli)"
args: [--line-length, "88"]
files: '^(ote_sdk|ote_cli)/.*\.py'
- id: black
name: "black - legacy (rest)"
args: [--line-length, "120"]
files: '^(external/anomaly|external/model-preparation-algorithm)/.*\.py'

- repo: https://github.com/PyCQA/flake8
rev: "5.0.3"
hooks:
- id: flake8
name: "flake8"
files: '^(ote_sdk|ote_cli|external/anomaly|external/model-preparation-algorithm)/.*\.py'
files: '^(otx|tests)/.*\.py'
args: ["--config", ".flake8", "--max-complexity", "20"]
exclude: ".*/protobuf"
exclude: "^(.*/protobuf|tests/ote_cli)"

# yaml formatting
- repo: https://github.com/pre-commit/mirrors-prettier
rev: v2.7.1
hooks:
- id: prettier
exclude: "external/deep-object-reid|otx/mpa|otx/recipes"
exclude: "external|otx/mpa|otx/recipes"

- repo: https://github.com/pre-commit/mirrors-mypy
rev: "v0.971"
Expand All @@ -76,35 +53,6 @@ repos:
]
exclude: "^otx/algorithms/anomaly/tests|otx/recipes|otx/mpa"

# NOTE: ote-sdk and ote-cli will be deprecated. The following config
# is to be removed.
- id: mypy
alias: mypy_ote_sdk
name: "mypy - legacy (ote_sdk)"
files: '^ote_sdk/.*\.py'
additional_dependencies:
[
numpy==1.19.5,
types-PyYAML,
attrs==21.2.*,
types-requests,
types-Deprecated,
types-docutils,
types_futures,
types-python-dateutil,
]
- id: mypy
alias: mypy_ote_cli
name: "mypy - legacy (ote_cli)"
files: '^ote_cli/.*\.py'
additional_dependencies: [types-PyYAML]
- id: mypy
alias: mypy_anomaly
name: "mypy (anomaly)"
files: '^external/anomaly/.*\.py'
additional_dependencies: [attrs==21.2.*, types-PyYAML]
exclude: "^external/anomaly/tests"

- repo: https://github.com/PyCQA/pylint
rev: "v2.14.5"
hooks:
Expand All @@ -117,17 +65,6 @@ repos:
types: [python]
args: ["--score=no"]

# NOTE: ote-sdk and ote-cli will be deprecated. The following config
# is to be removed.
- id: pylint
name: "pylint - legacy"
files: '^(ote_sdk|ote_cli|external/anomaly)/.*\.py'
entry: pylint
language: system
types: [python]
args: ["--score=no"]
exclude: "tests"

- repo: https://github.com/PyCQA/pydocstyle
rev: 6.1.1
hooks:
Expand All @@ -140,12 +77,13 @@ repos:
files: '^otx/.*\.py'
exclude: "otx/algorithms/anomaly/tests|external/anomaly/tests|otx/cli/utils/tests.py|otx/mpa|otx/recipes"

- repo: https://github.com/jumanjihouse/pre-commit-hooks
rev: 2.1.6
hooks:
- id: markdownlint
# TODO: Check all files even tests after migration to otx is complete
exclude: "^(ote_sdk|tests|.github)"
# Will use rst
# - repo: https://github.com/jumanjihouse/pre-commit-hooks
# rev: 2.1.6
# hooks:
# - id: markdownlint
# # TODO: Check all files even tests after migration to otx is complete
# exclude: "^(ote_sdk|tests|.github|external)"

- repo: https://github.com/AleksaC/hadolint-py
rev: v2.10.0
Expand Down
38 changes: 38 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,44 @@

All notable changes to this project will be documented in this file.

## \[v0.4.0\]

### Added

- Model Preparation Algorithm (MPA)
- Better saliency map support
- Replace current saliency map generation with Recipro-CAM for cls (<https://github.com/openvinotoolkit/training_extensions/pull/1363>)
- Class-wise saliency map generation for the detection task (<https://github.com/openvinotoolkit/training_extensions/pull/1402>)
- Improve object counting algorithm for high-res images via image tiling
- Add Tiling Module (<https://github.com/openvinotoolkit/training_extensions/pull/1200>)
- Fliter object less than 1 pixel (<https://github.com/openvinotoolkit/training_extensions/pull/1305>)
- Tiling deployment (<https://github.com/openvinotoolkit/training_extensions/pull/1387>)
- Enable tiling oriented detection for v0.4.0/geti1.1.0 (<https://github.com/openvinotoolkit/training_extensions/pull/1427>)

### Fixed

- Hot-fix for Detection fix two stage error (<https://github.com/openvinotoolkit/training_extensions/pull/1433>)
- Some minor issues

## \[v0.3.1\]

### Fixed

- Neural Network Compression Framework (NNCF)

- Fix CUDA OOM for NNCF optimization model MaskRCNN-EfficientNetB2B (<https://github.com/openvinotoolkit/training_extensions/pull/1319>)

- Model Preparation Algorithm (MPA)
- Fix 'Shape out of bounds' error when accepting AI predictions for detection oriented (<https://github.com/openvinotoolkit/training_extensions/pull/1326>)
- Fix weird confidence behaviour issue on predictions for hierarchical classification (<https://github.com/openvinotoolkit/training_extensions/pull/1332>)
- Fix training failure issue for hierarchical classification (<https://github.com/openvinotoolkit/training_extensions/pull/1329>)
- Fix training failure issues for segmentation and instance segmentation during inference process (<https://github.com/openvinotoolkit/training_extensions/pull/1338>)
- Some minor issues

### Security

- Update vulnerable Python dependencies in OTE (<https://github.com/openvinotoolkit/training_extensions/pull/1303>)

## \[v0.3.0\]

### Added
Expand Down
Loading