Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine HPO #2175

Merged
Merged

Conversation

eunwoosh
Copy link
Contributor

@eunwoosh eunwoosh commented May 23, 2023

Summary

This PR includes some refinements for HPO. Details are as below:

  • Terminate HPO trials when main process gets SIGINT or SIGTERM
  • HPO is suspended if HPO trials exists abnormally more than three times
  • Remove unused model weight after HPO is done
  • Fix a bug that HPO trial process waits to receive response infinitely if main process exits abnormally
  • Fix a bug that HPO trails early stopped sometimes when HPO with multi-GPU

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added CLI Any changes in OTE CLI TEST Any changes in tests DOC Improvements or additions to documentation labels May 23, 2023
@eunwoosh eunwoosh marked this pull request as ready for review May 23, 2023 02:11
@eunwoosh eunwoosh requested a review from a team as a code owner May 23, 2023 02:11
@eunwoosh eunwoosh added this to the 1.3.0 milestone May 23, 2023
@eunwoosh eunwoosh marked this pull request as draft May 23, 2023 02:18
@eunwoosh eunwoosh marked this pull request as ready for review May 23, 2023 02:33
@eunwoosh eunwoosh force-pushed the es/change_pipe_to_queue_in_hpo branch from 7bf6d43 to 06790e8 Compare May 23, 2023 02:36
@eunwoosh eunwoosh modified the milestones: 1.3.0, 1.4.0 May 23, 2023
@github-actions github-actions bot added the API Any changes in OTX API label May 23, 2023
@sungmanc sungmanc merged commit ca29281 into openvinotoolkit:develop May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Any changes in OTX API CLI Any changes in OTE CLI DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants