Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease a time for making a workspace #2223

Merged

Conversation

eunwoosh
Copy link
Contributor

@eunwoosh eunwoosh commented Jun 7, 2023

Summary

To decrease time for making a workspace, remove a code to reformat the python text using yapf.
This change makes python file saved in workspace a little unprettier, but it's still human readable.
How much time can be saved is as below:

  • classification : -0.1 sec
  • detection : -1.2 sec
  • segmentation : -0.6 sec

Added code is copied from mmcv but remove yapf part.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@eunwoosh eunwoosh added this to the 1.4.0 milestone Jun 7, 2023
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Jun 7, 2023
@eunwoosh eunwoosh changed the title do not use pretty text Decrease a time for making a workspace Jun 7, 2023
@github-actions github-actions bot added the DOC Improvements or additions to documentation label Jun 7, 2023
@eunwoosh eunwoosh marked this pull request as ready for review June 7, 2023 07:21
@eunwoosh eunwoosh requested a review from a team as a code owner June 7, 2023 07:21
sungmanc
sungmanc previously approved these changes Jun 7, 2023
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with minor comment

otx/algorithms/common/adapters/mmcv/utils/config_utils.py Outdated Show resolved Hide resolved
goodsong81
goodsong81 previously approved these changes Jun 7, 2023
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little bit concerned about copying code block, but let's keep going.
Better if we have a small test for the block.

@eunwoosh eunwoosh dismissed stale reviews from goodsong81 and sungmanc via a5124ea June 7, 2023 08:22
@goodsong81 goodsong81 merged commit a2a7999 into openvinotoolkit:develop Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants