Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deit_tiny template by default #2282

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Enable deit_tiny template by default #2282

merged 3 commits into from
Jul 7, 2023

Conversation

wonjuleee
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@wonjuleee wonjuleee requested a review from a team as a code owner June 30, 2023 04:21
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Jun 30, 2023
jaegukhyun
jaegukhyun previously approved these changes Jun 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e5b1000) 0.00% compared to head (32ac1e7) 0.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #2282   +/-   ##
=======================================
  Coverage     0.00%   0.00%           
=======================================
  Files          498     498           
  Lines        37574   37577    +3     
=======================================
- Misses       37574   37577    +3     
Flag Coverage Δ
py310 0.00% <0.00%> (ø)
py38 0.00% <0.00%> (ø)
py39 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...x/algorithms/classification/adapters/mmcls/task.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

harimkang
harimkang previously approved these changes Jun 30, 2023
@sungmanc
Copy link
Contributor

sungmanc commented Jul 3, 2023

@wonjuleee , is it okay to merge? or do you want to merge this PR after checking the effect of the Geti side?

Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold this PR until the Geti implements static model template mapping. It's OK for testing purpose.

@JihwanEom
Copy link
Contributor

Sorry for interrupting, we need to check documentation coverage if we promote DeiT template as default.

FYI, the performance of multi-label and h-label classification is not validated for DeiT template. Thanks!

@wonjuleee wonjuleee dismissed stale reviews from harimkang and jaegukhyun via 3fd0156 July 5, 2023 07:25
@github-actions github-actions bot removed the ALGO Any changes in OTX Algo Tasks implementation label Jul 5, 2023
@wonjuleee
Copy link
Contributor Author

@wonjuleee , is it okay to merge? or do you want to merge this PR after checking the effect of the Geti side?

I am currently working on manual testing on Geti.
I temporarily copied the data_cfg in mmcls task. @jaegukhyun, please let me know when you create the related PR. I will update this after merging your PR.

@wonjuleee wonjuleee force-pushed the wonju/deit_enable branch from 85c5994 to 06c4d85 Compare July 6, 2023 00:56
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels Jul 6, 2023
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that DeiT is registered as custom model on Geti.

@goodsong81 goodsong81 added this to the 1.4.0 milestone Jul 7, 2023
@goodsong81 goodsong81 merged commit ee7610e into develop Jul 7, 2023
@goodsong81 goodsong81 deleted the wonju/deit_enable branch July 7, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants