Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] XAI: Return saliency maps for Mask RCNN IR async infer #2391

Conversation

GalyaZalesskaya
Copy link
Contributor

@GalyaZalesskaya GalyaZalesskaya commented Jul 21, 2023

Summary

Fix the issue CVS-116159
Add for async inference calculating saliency maps from predictions (Mask RCNN IR)

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@GalyaZalesskaya GalyaZalesskaya requested a review from a team as a code owner July 21, 2023 15:08
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Jul 21, 2023
@GalyaZalesskaya GalyaZalesskaya added the FIX defect fix label Jul 21, 2023
@sungmanc
Copy link
Contributor

Since the exposure level of the ticket is E2, I think we need to apply this remedy to 1.4.1 or another RC. Please check this.

@goodsong81
Copy link
Contributor

@GalyaZalesskaya Could you replicate this fix to releases/1.4.0, too? We decided to use this branch for on-going fixes like 1.4.1+ for Geti1.8.

@GalyaZalesskaya GalyaZalesskaya changed the title XAI: Return saliency maps for Mask RCNN IR async infer [develop] XAI: Return saliency maps for Mask RCNN IR async infer Jul 24, 2023
@GalyaZalesskaya
Copy link
Contributor Author

@sungmanc @goodsong81 Thank you for the comment, I've created the same PR for the release branch: #2395

Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@goodsong81 goodsong81 merged commit 22a1573 into openvinotoolkit:develop Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation FIX defect fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants