-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getting wrong shape during resizing #3644
Fix getting wrong shape during resizing #3644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work :) I left minor comment. Please take a look.
Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sungchul2 I added my comments. Please take a look. Thanks!
@sungchul2 Could you also verify if the changes in this PR are covered by unit tests? If not, could you add a unit test to cover them? Thanks. |
Thanks for the suggestion! I updated unit tests to cover this issue, 35b0fb5. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3644 +/- ##
===========================================
- Coverage 78.59% 78.24% -0.36%
===========================================
Files 260 260
Lines 26593 26606 +13
===========================================
- Hits 20901 20818 -83
- Misses 5692 5788 +96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Summary
ticket no. : 144473
After #3582, if
img
is tensor wrong image shape is obtained during resize.training_extensions/src/otx/core/data/transform_libs/torchvision.py
Line 533 in a62e09d
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.