Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove setup on first row constraint #1235

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

jonathanpwang
Copy link
Contributor

We revert to enforcing at the program code level that:

  • a valid program must call the correct setup opcodes to be correct

It would be better if we can constraint this in the circuit, however this has the challenge that when the same chip is used across continuation segments, only the first segment will have setup called.

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair 3,371 711,968 25,526,194 - - -
fibonacci_program (+22 [+0.4%]) 6,094 1,500,137 51,505,102 - - -
regex_program 18,972 4,190,904 165,028,173 - - -
ecrecover_program 2,601 285,401 15,092,297 - - -

Commit: 72580b8

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit be2d4e4 into main Jan 18, 2025
17 checks passed
@jonathanpwang jonathanpwang deleted the fix/no_setup_constraint branch January 18, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant