Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: adding test utils crate #23

Merged
merged 54 commits into from
May 17, 2024
Merged

Conversation

OsamaAlkhodairy
Copy link
Contributor

Created a test-utils crate, and moved files that will be used by tests both for stark-backend/ and chips/ there.

jonathanpwang and others added 30 commits May 9, 2024 20:15
Merge branch 'main' into feat/main_trace_parts
* feat: add backend readme

* fix: link

* fix: link

* fix: latex

* chore: fix typo

* chore: add code references

---------

Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com>
No need for tracing on non-benchmark tests
jonathanpwang and others added 22 commits May 14, 2024 15:45
* fix: `eval_permutation_constraints` must handle partitioned_main

* feat: integration test with cached trace

* fix: forgot to add test files

* chore: rename folder to `partitioned_sum_air`

* chore: add test utils module

* feat: add indexless cached lookup test for partitioned Air with interactions

* chore: fix typo

* feat: `add_main_matrix(width)` placeholder with mat width

* chore: switch from RefCell to Arc Mutex
- `afs-middleware` -> `afs-stark-backend`
- `afs-middleware-derive` -> `afs-derive`

Imports can be handled by global find/replace.
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be annoying, but I have a bunch of nits on how the imports should be organized and ordered. Just want to enforce this so things stay pretty.

Other request is to keep cached trace integration tests inside stark-backend for now.

test-utils/Cargo.toml Outdated Show resolved Hide resolved
test-utils/Cargo.toml Show resolved Hide resolved
chips/tests/integration_test.rs Outdated Show resolved Hide resolved
stark-backend/tests/integration_test.rs Outdated Show resolved Hide resolved
stark-backend/tests/interaction/mod.rs Outdated Show resolved Hide resolved
test-utils/src/lib.rs Outdated Show resolved Hide resolved
test-utils/src/utils.rs Show resolved Hide resolved
test-utils/tests/integration_test.rs Outdated Show resolved Hide resolved
test-utils/src/cached_lookup/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanpwang jonathanpwang merged commit d92e125 into main May 17, 2024
4 checks passed
@jonathanpwang jonathanpwang deleted the chore/adding_test_utils_crate branch May 17, 2024 17:14
luffykai pushed a commit that referenced this pull request Dec 13, 2024
* wip: refactor to use commit pointers

* wip: permutation trace from partitioned main

* wip: fix previous rebase

* wip

* wip: show new interface

* chore: rename ChipsetProver to MultiTraceStarkProver

* test: added ListChip and a test involving RangeCheckerChip and ListChip

* chore: changed to using determinstic seed

* feat: quotient refactor done

* feat: prover done

* chore: split out prove function into general post-trace part

* feat: finished verifier

* feat: keygen builder

* chore: move fib triple test into same file

* test: testing thread safety and other improvements

* test: testing thread safety and other improvements

* test: generating traces in parallel

* feat: preliminary docs on STARK backend scope/support (#16)

* feat: add backend readme

* fix: link

* fix: link

* fix: latex

* chore: fix typo

* chore: add code references

---------

Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com>

* chore: make DebugBuilder `after_challenge` consistent with other builders

* chore: clean up if statement

* test: testing RangeCheckerChip

* chore: fix fmt

* chore: fix previous merge and remove tracing

No need for tracing on non-benchmark tests

* chore: fix lint

* fix: `eval_permutation_constraints` must handle partitioned_main

* feat: integration test with cached trace

* fix: forgot to add test files

* chore: rename folder to `partitioned_sum_air`

* chore: add test utils module

* feat: added XorChip

* chore: small fix

* feat: add indexless cached lookup test for partitioned Air with interactions

* feat: Partitioned Air Builder (#17)

* fix: `eval_permutation_constraints` must handle partitioned_main

* feat: integration test with cached trace

* fix: forgot to add test files

* chore: rename folder to `partitioned_sum_air`

* chore: add test utils module

* feat: add indexless cached lookup test for partitioned Air with interactions

* chore: fix typo

* feat: `add_main_matrix(width)` placeholder with mat width

* chore: switch from RefCell to Arc Mutex

* feat: added relative indexing and some documentation

* wip

* chore: simplifying trace.rs

* chore: rename crates `afs-stark-backend, afs-derive`

- `afs-middleware` -> `afs-stark-backend`
- `afs-middleware-derive` -> `afs-derive`

Imports can be handled by global find/replace.

* chore: fix github workflow

* chore: fix workflow name

* chore: set up concurrency for workflow

* chore: added test-utils crate

* chore: removing the xor chip

* wip

* chore: moving the tests to a tests/ directory in test-utils crate

* chore: fixing imports and moving cached_lookup to stark-backend

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants