feat: xor limbs chip #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpwang
approved these changes
May 22, 2024
jonathanpwang
approved these changes
May 23, 2024
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
* test: added negative test for xor_chip * chore: reordering imports * fix: made the xor chip thread-safe and other improvements * chore: adding Cargo.lock * chore: pruning Cargo.lock * fix: fixing Cargo.lock * wip * wip * feat: added xor_limbs and xor_lookup chips and tests for them * chore: adding some comments * chore: removing Cargo.lock * feat: added a proving helper in test_utils and used it in the xor_limbs tests * chore: renaming function to run_simple_test * chore: adding doc comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two chips: XorLimbsChip and XorLookupChip (see comments above the chip struct for explanation of what they do). Also added a positive and a negative test involving them.