Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename *ProvingKey to *PartialProvingKey #31

Merged
merged 1 commit into from
May 28, 2024

Conversation

jonathanpwang
Copy link
Contributor

  • run_simple_test now works with public values (run_simple_test_no_pis is version without)
  • Also changed integration tests to use run_simple_test

Only changed pk to partial_pk in external functions. I kept just pk in internal functions because (1) it's tedious to change, (2) if we do create a full pk in the future we'd need to change it back anyways.

@jonathanpwang jonathanpwang merged commit 6db59d9 into main May 28, 2024
4 checks passed
@jonathanpwang jonathanpwang deleted the chore/partial_vk branch May 28, 2024 00:45
luffykai pushed a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant