Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change MAX generic to instance field #40

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

bfan05
Copy link
Contributor

@bfan05 bfan05 commented Jun 3, 2024

Changed generic MAX to instance field for RangeCheckerChip, RangeCheckerGateChip, and ListChip.

Copy link
Contributor

@nyunyunyunyu nyunyunyunyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfan05 bfan05 merged commit ec33ee5 into main Jun 3, 2024
3 checks passed
@bfan05 bfan05 deleted the chore/max-instance branch June 3, 2024 17:51
luffykai pushed a commit that referenced this pull request Dec 13, 2024
* chore: change generic MAX to instance field for RangeCheckerChip, RangeCheckerGateChip, and ListChip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants