Add SumChip #42
Merged
Add SumChip #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this implements the V0 part of the onboarding project. Not sure if we want to merge this, but making PR for feedback. |
zlangley
commented
Jun 3, 2024
| when_first_row.assert_eq(local.partial_sum, local.input); | ||
|
|
||
| let mut when_transition = builder.when_transition(); | ||
| when_transition.assert_eq(next.partial_sum, local.partial_sum + next.input); |
There was a problem hiding this comment.
Are we concerned about overflow?
There was a problem hiding this comment.
good point: for this particular chip, we define sum to mean as field elements, but indeed if we specified some bit range then we would need to add overflow constraints
jonathanpwang
approved these changes
Jun 3, 2024
| when_first_row.assert_eq(local.partial_sum, local.input); | ||
|
|
||
| let mut when_transition = builder.when_transition(); | ||
| when_transition.assert_eq(next.partial_sum, local.partial_sum + next.input); |
There was a problem hiding this comment.
good point: for this particular chip, we define sum to mean as field elements, but indeed if we specified some bit range then we would need to add overflow constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.