feat: constrain nonzero divisor #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to add some kind of negative test checking that OpCode = DIV and x, y = 0 fails. |
|
Noting this is waiting on tests |
|
@cocohearts this still needs tests |
|
sorry was going to try to wait and fix the (small) issue where stdout would print long backtrace even when expecting panic, but ignored, negative tests pass as intended |
jonathanpwang
approved these changes
Jun 29, 2024
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
* feat: quotient inverse olumn to constain nonzero divisor when operation is division * chore: clean unused code * feat: negative tests that panic/confirm constraints fail --------- Co-authored-by: Alex Zhao <alexzhao@intrinsictech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional quotient inverse column to constrain nonzero divisor when operation is division.