Feat/PRINTF and FAIL instructions + make instruction set expansion easier #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlangley
approved these changes
Jun 28, 2024
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
…sier (#98) * Add PRINT and FAIL instructions, make improvements for variable instruction set * Fix lint * Use FAIL * Remove debug statement and convert panics to asserts * Add pc field to ExecutionError::Fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PRINTF and FAIL instructions. PRINTF is used for debugging and will cause
generate_program_executionto print out the field element at addressain address spaced; the trace generated will not be verifiable. FAIL will causegenerate_program_executionto fail (returnErr). Neither affects the AIR constraints as they can never appear in a verifiable execution (in this way, a program that fails cannot be verified, which seems desirable).The eDSL instructions PrintV and PrintF are compiled to PRINTF. The eDSL instruction Trap is compiled to FAIL. Additionally, FAIL is used in the program AIR to pad the trace.
Change
generate_program_executionto return aResultand introduce theExecutionErrorenum to capture the possible failure modes.Overhaul how enabling/disabling instruction sets is handled to make (near) future expansion easier.