Add python requirements file and update dependabot workflow #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
WadeBarnes
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
LGTM. I'll defer to @andrewwhitehead about the indy dependency.
jamshale
pushed a commit
to jamshale/askar
that referenced
this pull request
Aug 18, 2024
…quirements Add python requirements file and update dependabot workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently setup.py just indicates one dependency:
cached_property.It makes sense if the dependencies were parsed from a requirements.txt file (less effort than migrating to pyproject.toml format). Allows for easier management if any extras need to be added, and also means we can add pip dependency management to the dependabot workflow (namely to catch if there's an update to
cached_property.A requirements.dev.txt file is also added to track dev / test dependencies. I would add indy as a test requirement, since it's used in
indy_test.py, but I can't find out whichindypackages it's referring to ... it doesn't work withpip install indyorpython3-indy. So for now I've just specifiedpytestandpytest-asyncio