✨ add `order_by` and `descending` options to scan and fetch_all queries #291

ff137 · 2024-07-25T10:21:44Z

Closes #290

Adds ordering functionality to scan and fetch_all queries, to allow for custom ordering of fetched storage records.

Signed-off-by: ff137 <ff137@proton.me>

ff137 · 2024-07-26T12:16:42Z

Ready for review!

I wanted to test compatibility with ACA-Py, but building and installing the python wrapper from my local branch, and running pytest in ACA-Py, gives me:

...
INTERNALERROR>     get_library()
INTERNALERROR>   File "/root/anaconda3/envs/acapy/lib/python3.12/site-packages/aries_askar/bindings/__init__.py", line 44, in get_library
INTERNALERROR>     LIB.loaded
INTERNALERROR>   File "/root/anaconda3/envs/acapy/lib/python3.12/site-packages/aries_askar/bindings/lib.py", line 352, in loaded
INTERNALERROR>     self._lib = LibLoad(self.__class__.LIB_NAME)
INTERNALERROR>                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/root/anaconda3/envs/acapy/lib/python3.12/site-packages/aries_askar/bindings/lib.py", line 106, in __init__
INTERNALERROR>     self._load_library()
INTERNALERROR>   File "/root/anaconda3/envs/acapy/lib/python3.12/site-packages/aries_askar/bindings/lib.py", line 129, in _load_library
INTERNALERROR>     raise AskarError(
INTERNALERROR> aries_askar.error.AskarError: Library not found in path: aries_askar

This resolves when I revert to installing official pypi package with pip install aries_askar. So, there must be some extra step required when calling pip install . in the aries-askar/wrappers/python dir.

I tried adding aries-askar/target/release to LD_LIBRARY_PATH, but no dice.

If anyone can assist or direct me on how to set this up for local testing with ACA-Py, will be much appreciated!

ff137 · 2024-07-26T12:21:34Z

A logical extension would be to add the custom ordering option to "fetch all" queries as well (in a future PR)

ff137 · 2024-08-05T18:20:09Z

Good news! Managed to successfully test the changes locally 🚀
after copying target/release/libaries_askar.so to wrappers/python/aries_askar 🚚

Happy to confirm that all the ACA-Py tests pass using this branch's changes ✅
Will begin implementing the order_by functionality for ACA-Py soon™️

askar-storage/src/backend/db_utils.rs

Signed-off-by: ff137 <ff137@proton.me>

ff137 · 2024-08-15T17:17:21Z

I think I'm gonna try add the ordering options for fetching all records -- not just for scanning.
Makes sense imo to include it all in one PR

Signed-off-by: ff137 <ff137@proton.me>

ff137 · 2024-08-16T20:09:59Z

I've expanded ordering options to the fetch_all method as well.

I can confirm python wrapper works with changes (ACA-Py tests pass using this build).

JavaScript wrapper still has some tests that remain to be fixed ...

Signed-off-by: ff137 <ff137@proton.me>

ff137 · 2024-08-19T21:33:57Z

@andrewwhitehead Please let me know if you've had moment to review, if there are any additional steps necessary here. Maybe changing default behavior, or implementing some specific tests.

ACA-Py tests are passing with these changes here: openwallet-foundation/acapy#3173

And our end-to-end tests, asserting unique results across pages, are passing now (as described here:
openwallet-foundation/acapy#3173 (comment))

andrewwhitehead

Thanks, I think it looks good!

Signed-off-by: ff137 <ff137@proton.me>

* ✨ add `order_by` and `descending` options to query / scan and fetch_all methods Signed-off-by: ff137 <ff137@proton.me> * ✨ add `order_by` and `descending` options to PaginatedQuerySchema Signed-off-by: ff137 <ff137@proton.me> * ✨ modify `get_limit_offset` to `get_paginated_query_params` Signed-off-by: ff137 <ff137@proton.me> * ✨ add ordering to InMemoryStorage scan and fetch_all methods Signed-off-by: ff137 <ff137@proton.me> * 🚧 test in-progress aries-askar PR: openwallet-foundation/askar#291 Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Update lock file Signed-off-by: ff137 <ff137@proton.me> * 🎨 fix ruff warning Signed-off-by: ff137 <ff137@proton.me> * ✅ fix assertions Signed-off-by: ff137 <ff137@proton.me> * 🚧 test aries-askar with TestPyPI package Signed-off-by: ff137 <ff137@proton.me> * 🚧 test latest askar testpypi package Signed-off-by: ff137 <ff137@proton.me> * 🎨 Update order_by description and default value. Include in schema Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Update aries-askar test pypi package to pre-orjson feat release Signed-off-by: ff137 <ff137@proton.me> --------- Signed-off-by: ff137 <ff137@proton.me>

Signed-off-by: ff137 <ff137@proton.me>

* ✨ add `order_by` and `descending` options to query / scan and fetch_all methods Signed-off-by: ff137 <ff137@proton.me> * ✨ add `order_by` and `descending` options to PaginatedQuerySchema Signed-off-by: ff137 <ff137@proton.me> * ✨ modify `get_limit_offset` to `get_paginated_query_params` Signed-off-by: ff137 <ff137@proton.me> * ✨ add ordering to InMemoryStorage scan and fetch_all methods Signed-off-by: ff137 <ff137@proton.me> * 🚧 test in-progress aries-askar PR: openwallet-foundation/askar#291 Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Update lock file Signed-off-by: ff137 <ff137@proton.me> * 🎨 fix ruff warning Signed-off-by: ff137 <ff137@proton.me> * ✅ fix assertions Signed-off-by: ff137 <ff137@proton.me> * 🚧 test aries-askar with TestPyPI package Signed-off-by: ff137 <ff137@proton.me> * 🚧 test latest askar testpypi package Signed-off-by: ff137 <ff137@proton.me> * 🎨 Update order_by description and default value. Include in schema Signed-off-by: ff137 <ff137@proton.me> * 🐛 fix deserialisation of descending: bool parameter Signed-off-by: ff137 <ff137@proton.me> * ⏪ revert to testing 0.3.3b0 askar test package Signed-off-by: ff137 <ff137@proton.me> * 🔥 remove unnecessary record sorts (now that askar sorts by id == sorting by created_at) Signed-off-by: ff137 <ff137@proton.me> * ✅ fix test assertions -- wallet_list and connections_list no longer does additional sorting Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Update lock file Signed-off-by: ff137 <ff137@proton.me> --------- Signed-off-by: ff137 <ff137@proton.me>

* ✨ add `order_by` and `descending` options to query / scan and fetch_all methods Signed-off-by: ff137 <ff137@proton.me> * ✨ add `order_by` and `descending` options to PaginatedQuerySchema Signed-off-by: ff137 <ff137@proton.me> * ✨ modify `get_limit_offset` to `get_paginated_query_params` Signed-off-by: ff137 <ff137@proton.me> * ✨ add ordering to InMemoryStorage scan and fetch_all methods Signed-off-by: ff137 <ff137@proton.me> * 🚧 test in-progress aries-askar PR: openwallet-foundation/askar#291 Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Update lock file Signed-off-by: ff137 <ff137@proton.me> * 🎨 fix ruff warning Signed-off-by: ff137 <ff137@proton.me> * ✅ fix assertions Signed-off-by: ff137 <ff137@proton.me> * 🚧 test aries-askar with TestPyPI package Signed-off-by: ff137 <ff137@proton.me> * 🚧 test latest askar testpypi package Signed-off-by: ff137 <ff137@proton.me> * 🎨 Update order_by description and default value. Include in schema Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Update aries-askar test pypi package to pre-orjson feat release Signed-off-by: ff137 <ff137@proton.me> --------- Signed-off-by: ff137 <ff137@proton.me>

* ✨ add `order_by` and `descending` options to query / scan and fetch_all methods Signed-off-by: ff137 <ff137@proton.me> * ✨ add `order_by` and `descending` options to PaginatedQuerySchema Signed-off-by: ff137 <ff137@proton.me> * ✨ modify `get_limit_offset` to `get_paginated_query_params` Signed-off-by: ff137 <ff137@proton.me> * ✨ add ordering to InMemoryStorage scan and fetch_all methods Signed-off-by: ff137 <ff137@proton.me> * 🚧 test in-progress aries-askar PR: openwallet-foundation/askar#291 Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Update lock file Signed-off-by: ff137 <ff137@proton.me> * 🎨 fix ruff warning Signed-off-by: ff137 <ff137@proton.me> * ✅ fix assertions Signed-off-by: ff137 <ff137@proton.me> * 🚧 test aries-askar with TestPyPI package Signed-off-by: ff137 <ff137@proton.me> * 🚧 test latest askar testpypi package Signed-off-by: ff137 <ff137@proton.me> * 🎨 Update order_by description and default value. Include in schema Signed-off-by: ff137 <ff137@proton.me> * 🐛 fix deserialisation of descending: bool parameter Signed-off-by: ff137 <ff137@proton.me> * ⏪ revert to testing 0.3.3b0 askar test package Signed-off-by: ff137 <ff137@proton.me> * 🔥 remove unnecessary record sorts (now that askar sorts by id == sorting by created_at) Signed-off-by: ff137 <ff137@proton.me> * ✅ fix test assertions -- wallet_list and connections_list no longer does additional sorting Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Update lock file Signed-off-by: ff137 <ff137@proton.me> --------- Signed-off-by: ff137 <ff137@proton.me>

* Rebase the pagination with ordering feature on latest release (#2) * ✨ add `order_by` and `descending` options to query / scan and fetch_all methods Signed-off-by: ff137 <ff137@proton.me> * ✨ add `order_by` and `descending` options to PaginatedQuerySchema Signed-off-by: ff137 <ff137@proton.me> * ✨ modify `get_limit_offset` to `get_paginated_query_params` Signed-off-by: ff137 <ff137@proton.me> * ✨ add ordering to InMemoryStorage scan and fetch_all methods Signed-off-by: ff137 <ff137@proton.me> * 🚧 test in-progress aries-askar PR: openwallet-foundation/askar#291 Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Update lock file Signed-off-by: ff137 <ff137@proton.me> * 🎨 fix ruff warning Signed-off-by: ff137 <ff137@proton.me> * ✅ fix assertions Signed-off-by: ff137 <ff137@proton.me> * 🚧 test aries-askar with TestPyPI package Signed-off-by: ff137 <ff137@proton.me> * 🚧 test latest askar testpypi package Signed-off-by: ff137 <ff137@proton.me> * 🎨 Update order_by description and default value. Include in schema Signed-off-by: ff137 <ff137@proton.me> * 🐛 fix deserialisation of descending: bool parameter Signed-off-by: ff137 <ff137@proton.me> * ⏪ revert to testing 0.3.3b0 askar test package Signed-off-by: ff137 <ff137@proton.me> * 🔥 remove unnecessary record sorts (now that askar sorts by id == sorting by created_at) Signed-off-by: ff137 <ff137@proton.me> * ✅ fix test assertions -- wallet_list and connections_list no longer does additional sorting Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Update lock file Signed-off-by: ff137 <ff137@proton.me> --------- Signed-off-by: ff137 <ff137@proton.me> * arrow_up: Upgrade python-dateutil Resolves calling deprecated `datetime.utcfromtimestamp` method Signed-off-by: ff137 <ff137@proton.me> * art: Rename class to resolve PytestCollectionWarning Signed-off-by: ff137 <ff137@proton.me> * art: Replace deprecated `open_binary` method with `files` Signed-off-by: ff137 <ff137@proton.me> * art: Replace deprecated `scope` keyword with `loop_scope` Signed-off-by: ff137 <ff137@proton.me> * art: Filter Aries RFC 0160 DeprecationWarning in tests Signed-off-by: ff137 <ff137@proton.me> * art: Filter Pydantic UserWarning in test Signed-off-by: ff137 <ff137@proton.me> * arrow_up: Upgrade aiohttp to latest release and update lock file Signed-off-by: ff137 <ff137@proton.me> * art: Remove unnecessary asyncio pytest markers Resolves unclosed event loop warnings. Signed-off-by: ff137 <ff137@proton.me> --------- Signed-off-by: ff137 <ff137@proton.me>

…askar#291 Signed-off-by: ff137 <ff137@proton.me>

* ⬆️ Upgrade python-dateutil Resolves calling deprecated `datetime.utcfromtimestamp` method Signed-off-by: ff137 <ff137@proton.me> * 🎨 Rename class to resolve PytestCollectionWarning Signed-off-by: ff137 <ff137@proton.me> * 🎨 Replace deprecated `open_binary` method with `files` Signed-off-by: ff137 <ff137@proton.me> * 🎨 Replace deprecated `scope` keyword with `loop_scope` Signed-off-by: ff137 <ff137@proton.me> * 🎨 Filter Aries RFC 0160 DeprecationWarning in tests Signed-off-by: ff137 <ff137@proton.me> * 🎨 Filter Pydantic UserWarning in test Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Upgrade aiohttp to latest release and update lock file Signed-off-by: ff137 <ff137@proton.me> * 🎨 Remove unnecessary asyncio pytest markers Resolves unclosed event loop warnings. Signed-off-by: ff137 <ff137@proton.me> * chore(deps-dev): Bump ruff from 0.7.3 to 0.7.4 (openwallet-foundation#3341) Bumps [ruff](https://github.com/astral-sh/ruff) from 0.7.3 to 0.7.4. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.7.3...0.7.4) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump aiohttp from 3.11.0 to 3.11.2 (openwallet-foundation#3340) Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.11.0 to 3.11.2. - [Release notes](https://github.com/aio-libs/aiohttp/releases) - [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst) - [Commits](aio-libs/aiohttp@v3.11.0...v3.11.2) --- updated-dependencies: - dependency-name: aiohttp dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump pyjwt from 2.9.0 to 2.10.0 (openwallet-foundation#3339) Bumps [pyjwt](https://github.com/jpadilla/pyjwt) from 2.9.0 to 2.10.0. - [Release notes](https://github.com/jpadilla/pyjwt/releases) - [Changelog](https://github.com/jpadilla/pyjwt/blob/master/CHANGELOG.rst) - [Commits](jpadilla/pyjwt@2.9.0...2.10.0) --- updated-dependencies: - dependency-name: pyjwt dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * did:tdw resolver (openwallet-foundation#3237) * did:tdw resolver Signed-off-by: jamshale <jamiehalebc@gmail.com> * Update unit tests Signed-off-by: jamshale <jamiehalebc@gmail.com> * Update poetry.lock Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com> * chore(deps): Bump aiohttp (openwallet-foundation#3342) Bumps the pip group with 1 update in the /scenarios directory: [aiohttp](https://github.com/aio-libs/aiohttp). Updates `aiohttp` from 3.10.5 to 3.10.11 - [Release notes](https://github.com/aio-libs/aiohttp/releases) - [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst) - [Commits](aio-libs/aiohttp@v3.10.5...v3.10.11) --- updated-dependencies: - dependency-name: aiohttp dependency-type: indirect dependency-group: pip ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jamshale <31809382+jamshale@users.noreply.github.com> * 🎨 Refactor `register_plugin` steps for maintainability Signed-off-by: ff137 <ff137@proton.me> * 🎨 improve logging in register_package Signed-off-by: ff137 <ff137@proton.me> * 🎨 Rename method and remove redundant main call Signed-off-by: ff137 <ff137@proton.me> * 🎨 Signed-off-by: ff137 <ff137@proton.me> * 🔊 Add debug logging to Context Builder Signed-off-by: ff137 <ff137@proton.me> * 🎨 Deduplicate registering list of plugins Signed-off-by: ff137 <ff137@proton.me> * 🎨 Signed-off-by: ff137 <ff137@proton.me> * 🔊 Add debug logging to init_context Signed-off-by: ff137 <ff137@proton.me> * 🔊 Add debug logging to load_protocol_version Signed-off-by: ff137 <ff137@proton.me> * 🔊 Add debug logging to load_protocols Signed-off-by: ff137 <ff137@proton.me> * 🔊 Add debug logging to register_admin_routes Signed-off-by: ff137 <ff137@proton.me> * 🔊 Add debug logging to register_protocol_events Signed-off-by: ff137 <ff137@proton.me> * 🔊 Add debug logging to post_process_routes Signed-off-by: ff137 <ff137@proton.me> * 🎨 Replace print statements with info logs Signed-off-by: ff137 <ff137@proton.me> * 🎨 Replace almost all print statements with info logs Signed-off-by: ff137 <ff137@proton.me> * 🔊 Expand logging for Conductor setup Signed-off-by: ff137 <ff137@proton.me> * 🎨 Correct to uphold previous "Module doesn't exist" log behaviour Signed-off-by: ff137 <ff137@proton.me> * ✅ Fix test by using assertLogs instead of capturing stdout Signed-off-by: ff137 <ff137@proton.me> * Revert "🎨 Rename method and remove redundant main call" This reverts commit 2f6526d. Signed-off-by: ff137 <ff137@proton.me> * 🎨 Signed-off-by: ff137 <ff137@proton.me> * ✅ Fix test by adding __name__ to mock object Signed-off-by: ff137 <ff137@proton.me> * 🎨 Signed-off-by: ff137 <ff137@proton.me> * ✨ Add custom trace log level Signed-off-by: ff137 <ff137@proton.me> * 🎨 Ensure trace level can only be added once Signed-off-by: ff137 <ff137@proton.me> * 🎨 Add Logger Signed-off-by: ff137 <ff137@proton.me> * 🎨 Update newly added logs to be trace level instead of debug Signed-off-by: ff137 <ff137@proton.me> * 🎨 Update newly added logs to be trace level instead of debug Signed-off-by: ff137 <ff137@proton.me> * 🔊 Expand logging for Conductor start and stop Signed-off-by: ff137 <ff137@proton.me> * ✅ Add unit tests for adding trace level functionality Signed-off-by: ff137 <ff137@proton.me> * ✅ Reset the logging states before and after TestLoggingUtils is run Signed-off-by: ff137 <ff137@proton.me> * 🎨 Signed-off-by: ff137 <ff137@proton.me> * 🧪 Debug log assertion test failing sporadically Filter the logs being read by module name, and add short sleep to allow log handlers to flush Signed-off-by: ff137 <ff137@proton.me> * ✅ Modify log assertion to be more robust Signed-off-by: ff137 <ff137@proton.me> * 🎨 Signed-off-by: ff137 <ff137@proton.me> * 🐛 Handle case that load_module return type is Optional Signed-off-by: ff137 <ff137@proton.me> * 🔊 Expand logging for ClassLoader Signed-off-by: ff137 <ff137@proton.me> * 🔊 Log a warning if resource not found, instead of passing Signed-off-by: ff137 <ff137@proton.me> * 🎨 Signed-off-by: ff137 <ff137@proton.me> * 🎨 Enable trace logs for remaining modules Signed-off-by: ff137 <ff137@proton.me> * 🐛 Fix registering and loading of modules Signed-off-by: ff137 <ff137@proton.me> * 🔊 Expand logging for Ledger Configuration Signed-off-by: ff137 <ff137@proton.me> * Fix tails upload for anoncreds multitenancy Signed-off-by: jamshale <jamiehalebc@gmail.com> * Update unit test Signed-off-by: jamshale <jamiehalebc@gmail.com> * Make sonarcloud happy with https in test Signed-off-by: jamshale <jamiehalebc@gmail.com> * Add anoncreds issuance and presentation format (openwallet-foundation#3331) * Add anoncreds issuance and presentation formats Signed-off-by: jamshale <jamiehalebc@gmail.com> * Fix unit tests Signed-off-by: jamshale <jamiehalebc@gmail.com> * Fix error in _formats_attach Signed-off-by: jamshale <jamiehalebc@gmail.com> * Fix AnoncredsDID validation pattern Signed-off-by: jamshale <jamiehalebc@gmail.com> * Fix name Signed-off-by: jamshale <jamiehalebc@gmail.com> * Fix scenario test Signed-off-by: jamshale <jamiehalebc@gmail.com> * Update demo with anoncreds format Signed-off-by: jamshale <jamiehalebc@gmail.com> * Fix the scenario test and add better description Signed-off-by: jamshale <jamiehalebc@gmail.com> * Add service_healthy check for indy agent Signed-off-by: jamshale <jamiehalebc@gmail.com> * Fix/update BDD tests Signed-off-by: jamshale <jamiehalebc@gmail.com> * Add issuer askar to holder anoncreds support Signed-off-by: jamshale <jamiehalebc@gmail.com> * Update BDD tests Signed-off-by: jamshale <jamiehalebc@gmail.com> * Remove commented code Signed-off-by: jamshale <jamiehalebc@gmail.com> * Expand scenario test Signed-off-by: jamshale <jamiehalebc@gmail.com> * Add better comments for format compatibilty imports Signed-off-by: jamshale <jamiehalebc@gmail.com> * Add anocnreds compatibilty bdd test to PR workflow Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com> * Fix handling of base_wallet_routes startup parameter in auth decorator Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com> * Restore --base-wallet-extra-routes argument functionality Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com> * Correctly handle null value for --base-wallet-routes Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com> * Fix typo Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com> * Fix subwallet anoncreds upgrade check (openwallet-foundation#3345) Signed-off-by: jamshale <jamiehalebc@gmail.com> * Fix/universal resolver (openwallet-foundation#3354) * Update universal resolver response handling Signed-off-by: jamshale <jamiehalebc@gmail.com> * Update universal resolver unit test Signed-off-by: jamshale <jamiehalebc@gmail.com> * Add reverse compatibility handling Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com> * chore(deps-dev): Bump ruff from 0.7.4 to 0.8.0 (openwallet-foundation#3348) Bumps [ruff](https://github.com/astral-sh/ruff) from 0.7.4 to 0.8.0. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.7.4...0.8.0) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jamshale <31809382+jamshale@users.noreply.github.com> * chore(deps): Bump mkdocs-material from 9.5.44 to 9.5.46 (openwallet-foundation#3352) Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.44 to 9.5.46. - [Release notes](https://github.com/squidfunk/mkdocs-material/releases) - [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG) - [Commits](squidfunk/mkdocs-material@9.5.44...9.5.46) --- updated-dependencies: - dependency-name: mkdocs-material dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump uuid-utils from 0.9.0 to 0.10.0 (openwallet-foundation#3351) Bumps [uuid-utils](https://github.com/aminalaee/uuid-utils) from 0.9.0 to 0.10.0. - [Release notes](https://github.com/aminalaee/uuid-utils/releases) - [Commits](aminalaee/uuid-utils@0.9.0...0.10.0) --- updated-dependencies: - dependency-name: uuid-utils dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump debugpy from 1.8.8 to 1.8.9 (openwallet-foundation#3350) Bumps [debugpy](https://github.com/microsoft/debugpy) from 1.8.8 to 1.8.9. - [Release notes](https://github.com/microsoft/debugpy/releases) - [Commits](microsoft/debugpy@v1.8.8...v1.8.9) --- updated-dependencies: - dependency-name: debugpy dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump aiohttp from 3.11.2 to 3.11.7 (openwallet-foundation#3349) Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.11.2 to 3.11.7. - [Release notes](https://github.com/aio-libs/aiohttp/releases) - [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst) - [Commits](aio-libs/aiohttp@v3.11.2...v3.11.7) --- updated-dependencies: - dependency-name: aiohttp dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ⏪ Revert `trace` log changes, and move to debug level Signed-off-by: ff137 <ff137@proton.me> * ✨ Add caching to ClassLoader.load_module Signed-off-by: ff137 <ff137@proton.me> * 🎨 Improve log Signed-off-by: ff137 <ff137@proton.me> * 🎨 Sync Ruff version in configs and apply formatting (openwallet-foundation#3358) * ⬆️ Upgrade ruff version in pre-commit config and lint workflow Signed-off-by: ff137 <ff137@proton.me> * 🎨 Apply ruff formatting Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Upgrade pre-commit hook version Signed-off-by: ff137 <ff137@proton.me> --------- Signed-off-by: ff137 <ff137@proton.me> * 🎨 Replace deprecated ABC decorators (openwallet-foundation#3357) Signed-off-by: ff137 <ff137@proton.me> Co-authored-by: jamshale <31809382+jamshale@users.noreply.github.com> * 🎨 Reduce log verbosity Signed-off-by: ff137 <ff137@proton.me> * ✨ Add `lru_cache` to load_class and set maxsize Signed-off-by: ff137 <ff137@proton.me> * ⚡ Add class caching to DeferLoad Resolves openwallet-foundation#3360 Signed-off-by: ff137 <ff137@proton.me> * ⏪ Revert addition of lru caching Signed-off-by: ff137 <ff137@proton.me> * 🎨 Update logs / reduce verbosity Signed-off-by: ff137 <ff137@proton.me> * Revert "Don't pass rekey to sub_wallet_profile" This reverts commit e59d275. * Fixes openwallet-foundation#3202: new suppress banner and replace print by logging statements Signed-off-by: Ricky Ng-Adam <ricky.ng-adam-ext@mcn.gouv.qc.ca> * 🎨 Print agent label and version even if banner suppressed Signed-off-by: ff137 <ff137@proton.me> * ✅ Fix pagination assertions Signed-off-by: ff137 <ff137@proton.me> * 👷 Upload Python Package to TestPyPI (#4) * 👷 Upload Python Package to TestPyPI Signed-off-by: ff137 <ff137@proton.me> * 👷 Update project name and version for testpypi Signed-off-by: ff137 <ff137@proton.me> * 🎨 Signed-off-by: ff137 <ff137@proton.me> --------- Signed-off-by: ff137 <ff137@proton.me> * Version 1.1.1-20241115 Signed-off-by: ff137 <ff137@proton.me> * 🎨 Deprecate count/start query params and implement limit/offset (#6) * art: Modify count/start query params to be Integers, not Strings Signed-off-by: ff137 <ff137@proton.me> * memo: Update openapi spec Signed-off-by: ff137 <ff137@proton.me> * rewind: Revert start/count field to remain String type; mark as deprecated Signed-off-by: ff137 <ff137@proton.me> * sparkles: Implement limit/offset alongside deprecated count/start Signed-off-by: ff137 <ff137@proton.me> * art: Standardise naming convention from count/start to limit/offset Signed-off-by: ff137 <ff137@proton.me> * rewind: Revert start/count field to remain String type; mark as deprecated Signed-off-by: ff137 <ff137@proton.me> * sparkles: Implement limit/offset alongside deprecated count/start Signed-off-by: ff137 <ff137@proton.me> * art: Remove unused query string schema from `w3c_creds_list` Signed-off-by: ff137 <ff137@proton.me> * art: Rename args Signed-off-by: ff137 <ff137@proton.me> * memo: Update openapi specs Signed-off-by: ff137 <ff137@proton.me> * white_check_mark: Signed-off-by: ff137 <ff137@proton.me> --------- Signed-off-by: ff137 <ff137@proton.me> * sparkles: add `order_by` and `descending` options to query / scan and fetch_all methods Signed-off-by: ff137 <ff137@proton.me> * sparkles: add `order_by` and `descending` options to PaginatedQuerySchema Signed-off-by: ff137 <ff137@proton.me> * sparkles: modify `get_limit_offset` to `get_paginated_query_params` Signed-off-by: ff137 <ff137@proton.me> * construction: test in-progress aries-askar PR: openwallet-foundation/askar#291 Signed-off-by: ff137 <ff137@proton.me> * arrow_up: Update lock file Signed-off-by: ff137 <ff137@proton.me> * art: fix ruff warning Signed-off-by: ff137 <ff137@proton.me> * white_check_mark: fix assertions Signed-off-by: ff137 <ff137@proton.me> * construction: test aries-askar with TestPyPI package Signed-off-by: ff137 <ff137@proton.me> * construction: test latest askar testpypi package Signed-off-by: ff137 <ff137@proton.me> * art: Update order_by description and default value. Include in schema Signed-off-by: ff137 <ff137@proton.me> * bug: fix deserialisation of descending: bool parameter Signed-off-by: ff137 <ff137@proton.me> * rewind: revert to testing 0.3.3b0 askar test package Signed-off-by: ff137 <ff137@proton.me> * fire: remove unnecessary record sorts (now that askar sorts by id == sorting by created_at) Signed-off-by: ff137 <ff137@proton.me> * white_check_mark: fix test assertions -- wallet_list and connections_list no longer does additional sorting Signed-off-by: ff137 <ff137@proton.me> * arrow_up: Update lock file Signed-off-by: ff137 <ff137@proton.me> * art: Modify count/start query params to be Integers, not Strings Signed-off-by: ff137 <ff137@proton.me> * memo: Update openapi spec Signed-off-by: ff137 <ff137@proton.me> * rewind: Revert start/count field to remain String type; mark as deprecated Signed-off-by: ff137 <ff137@proton.me> * sparkles: Implement limit/offset alongside deprecated count/start Signed-off-by: ff137 <ff137@proton.me> * art: Standardise naming convention from count/start to limit/offset Signed-off-by: ff137 <ff137@proton.me> * rewind: Revert start/count field to remain String type; mark as deprecated Signed-off-by: ff137 <ff137@proton.me> * sparkles: Implement limit/offset alongside deprecated count/start Signed-off-by: ff137 <ff137@proton.me> * art: Remove unused query string schema from `w3c_creds_list` Signed-off-by: ff137 <ff137@proton.me> * art: Rename args Signed-off-by: ff137 <ff137@proton.me> * memo: Update openapi specs Signed-off-by: ff137 <ff137@proton.me> * white_check_mark: Signed-off-by: ff137 <ff137@proton.me> * art: Update start/count keywords to offset/limit Signed-off-by: ff137 <ff137@proton.me> * 🐛 Fix IndyVdrLedgerPool RuntimeWarning Resolves openwallet-foundation#3328 Signed-off-by: ff137 <ff137@proton.me> * 🧪 Update tests Signed-off-by: ff137 <ff137@proton.me> * Revert "did:tdw resolver (openwallet-foundation#3237)" This reverts commit f5c49b0. Signed-off-by: ff137 <ff137@proton.me> * 1.1.1b5 Signed-off-by: ff137 <ff137@proton.me> * 🎨 Propagate the async changes Signed-off-by: ff137 <ff137@proton.me> * 🎨 Propagate the async changes Signed-off-by: ff137 <ff137@proton.me> * Add test wallet config option (openwallet-foundation#3355) * Add test wallet config option Signed-off-by: jamshale <jamiehalebc@gmail.com> * Change wallet test arg to store true / Fix tests Signed-off-by: jamshale <jamiehalebc@gmail.com> * Add unit test with test wallet config Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com> * Week 49 Library upgrades (openwallet-foundation#3368) Signed-off-by: jamshale <jamiehalebc@gmail.com> * ⚡ Add class caching to DeferLoad (openwallet-foundation#3361) Resolves openwallet-foundation#3360 Signed-off-by: ff137 <ff137@proton.me> Co-authored-by: jamshale <31809382+jamshale@users.noreply.github.com> * fix: check routing keys on endpoint refresh Previously we were only checking if the endpoint value had changed but it is possible for the routing keys to update and not the endpoint. This resulted in new attrib txns not getting published when there were new routing keys. Signed-off-by: Daniel Bluhm <dbluhm@pm.me> * 1.1.1rc0 Signed-off-by: Stephen Curran <swcurran@gmail.com> * Make vc libraries mandatory (openwallet-foundation#3356) * Make vc libraries mandatory Signed-off-by: jamshale <jamiehalebc@gmail.com> * Make indy-vdr library required Signed-off-by: jamshale <jamiehalebc@gmail.com> * Update dockerfiles after removed extras Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com> * Update the PR for release Signed-off-by: Stephen Curran <swcurran@gmail.com> * Repair release bdd tests Signed-off-by: jamshale <jamiehalebc@gmail.com> * Add in PR to Changelog Signed-off-by: Stephen Curran <swcurran@gmail.com> * 🎨 Reduce repetition Signed-off-by: ff137 <ff137@proton.me> * Fix for demo initial cred_type override (openwallet-foundation#3378) Signed-off-by: Ian Costanzo <ian@anon-solutions.ca> * chore(deps): Bump dawidd6/action-download-artifact (openwallet-foundation#3370) Bumps the all-actions group with 1 update: [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact). Updates `dawidd6/action-download-artifact` from 6 to 7 - [Release notes](https://github.com/dawidd6/action-download-artifact/releases) - [Commits](dawidd6/action-download-artifact@v6...v7) --- updated-dependencies: - dependency-name: dawidd6/action-download-artifact dependency-type: direct:production update-type: version-update:semver-major dependency-group: all-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jamshale <31809382+jamshale@users.noreply.github.com> * 🎨 Log warning when StorageNotFoundError encountered, instead of exception stacktrace Signed-off-by: ff137 <ff137@proton.me> * 🎨 Set Shutdown log level to fatal, with exc_info Signed-off-by: ff137 <ff137@proton.me> * 🎨 Log warning for bad credential format, instead of always exception stacktrace Signed-off-by: ff137 <ff137@proton.me> * 🚧 Add exc_info to error log for debugging Signed-off-by: ff137 <ff137@proton.me> * 🎨 Make `ensure_supported_did` method public Signed-off-by: ff137 <ff137@proton.me> * 🐛 Ensure supported DID before calling Rotate Resolves: openwallet-foundation#3379 Signed-off-by: ff137 <ff137@proton.me> * ✅ Fix existing tests Signed-off-by: ff137 <ff137@proton.me> * ✅ Test coverage for new DID validation Signed-off-by: ff137 <ff137@proton.me> * 🎨 Shorten config key * 🎨 Fix lying method return type Signed-off-by: ff137 <ff137@proton.me> * 🎨 Replace AskarError with ProfileError Signed-off-by: ff137 <ff137@proton.me> * 🚧 Skip exception log for ProfileError Signed-off-by: ff137 <ff137@proton.me> * 🐛 Fix message type class mapping Signed-off-by: ff137 <ff137@proton.me> * 🚧 Debug message parse error Signed-off-by: ff137 <ff137@proton.me> * 🚧 Log warning instead of error for MessageParseError Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Bump version Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Update lock file Signed-off-by: ff137 <ff137@proton.me> * 🎨 Fix model name for consistency From Anoncred to Anoncreds Signed-off-by: ff137 <ff137@proton.me> * 🎨 Set wallet upgrade exception log to warning Signed-off-by: ff137 <ff137@proton.me> * Update anoncreds format names (openwallet-foundation#3374) * Update anoncreds format names Signed-off-by: jamshale <jamiehalebc@gmail.com> * Add a unit test Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com> * 🎨 Fix model name for consistency (openwallet-foundation#3382) From Anoncred to Anoncreds Signed-off-by: ff137 <ff137@proton.me> Co-authored-by: jamshale <31809382+jamshale@users.noreply.github.com> --------- Signed-off-by: ff137 <ff137@proton.me> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: jamshale <jamiehalebc@gmail.com> Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com> Signed-off-by: Ricky Ng-Adam <ricky.ng-adam-ext@mcn.gouv.qc.ca> Signed-off-by: Daniel Bluhm <dbluhm@pm.me> Signed-off-by: Stephen Curran <swcurran@gmail.com> Signed-off-by: Ian Costanzo <ian@anon-solutions.ca> Co-authored-by: Daniel Bluhm <dbluhm@pm.me> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jamshale <31809382+jamshale@users.noreply.github.com> Co-authored-by: jamshale <jamiehalebc@gmail.com> Co-authored-by: Stephen Curran <swcurran@gmail.com> Co-authored-by: Emiliano Suñé <emiliano.sune@gmail.com> Co-authored-by: Ricky Ng-Adam <ricky.ng-adam-ext@mcn.gouv.qc.ca> Co-authored-by: Ian Costanzo <ian@anon-solutions.ca>

ff137 added 6 commits July 25, 2024 13:20

🚧 add order_by and descending argument to scan

744cfe9

Signed-off-by: ff137 <ff137@proton.me>

🎨 format

29018ee

Signed-off-by: ff137 <ff137@proton.me>

🎨 use Ffi types for order_by and descending

f03ac9f

Signed-off-by: ff137 <ff137@proton.me>

🎨 replace Option[bool] with bool

93bcae6

Signed-off-by: ff137 <ff137@proton.me>

🎨 fix order_by and descending reference

1dadd5a

Signed-off-by: ff137 <ff137@proton.me>

✨ add order_by and descending options to python Scan object

a38d6dc

Signed-off-by: ff137 <ff137@proton.me>

ff137 force-pushed the feat/order-by-scan branch from f8bddd4 to d338cc0 Compare July 26, 2024 11:37

✨ add order_by and descending options to scan in javascript wrapper

cf5787e

Signed-off-by: ff137 <ff137@proton.me>

ff137 force-pushed the feat/order-by-scan branch from d338cc0 to cf5787e Compare July 26, 2024 12:01

ff137 changed the title ~~🚧 WIP: add ordering options to scan query~~ ✨ add ordering options to scan query Jul 26, 2024

ff137 marked this pull request as ready for review July 26, 2024 12:10

andrewwhitehead reviewed Aug 7, 2024

View reviewed changes

askar-storage/src/backend/db_utils.rs Outdated Show resolved Hide resolved

ff137 marked this pull request as draft August 7, 2024 07:38

ff137 added 3 commits August 15, 2024 15:01

✨ implement OrderBy as Enum, with Default impl

aee343e

Signed-off-by: ff137 <ff137@proton.me>

🎨 order_by_query now takes OrderBy enum directly, instead of Option.

974e996

Signed-off-by: ff137 <ff137@proton.me>

✨ Only add ordering, and limit/offset, if the query starts with SELECT

1a37edf

Signed-off-by: ff137 <ff137@proton.me>

ff137 marked this pull request as ready for review August 15, 2024 12:10

ff137 changed the title ~~✨ add ordering options to scan query~~ ✨ add order_by and descending options to scan and fetch_all queries Aug 16, 2024

✨ expand ordering functionality to fetch_all query

2efcade

Signed-off-by: ff137 <ff137@proton.me>

ff137 requested a review from andrewwhitehead August 16, 2024 20:09

ff137 added 2 commits August 16, 2024 23:14

✅ fix tests

0a9dd4f

Signed-off-by: ff137 <ff137@proton.me>

🐛 fix arg type order

6272b1f

Signed-off-by: ff137 <ff137@proton.me>

ff137 added a commit to ff137/acapy that referenced this pull request Aug 16, 2024

🚧 test in-progress aries-askar PR: openwallet-foundation/askar#291

0e7940e

Signed-off-by: ff137 <ff137@proton.me>

ff137 mentioned this pull request Aug 16, 2024

✨ Add ordering options to askar scan and fetch_all methods openwallet-foundation/acapy#3173

Merged

🐛 add missing arguments

bd11dfe

Signed-off-by: ff137 <ff137@proton.me>

ff137 force-pushed the feat/order-by-scan branch from fe5c8a9 to bd11dfe Compare August 16, 2024 21:20

🎨 fix lint errors

7eb7763

Signed-off-by: ff137 <ff137@proton.me>

ff137 added a commit to ff137/acapy that referenced this pull request Aug 19, 2024

🚧 test in-progress aries-askar PR: openwallet-foundation/askar#291

07a5c5a

Signed-off-by: ff137 <ff137@proton.me>

andrewwhitehead approved these changes Aug 20, 2024

View reviewed changes

andrewwhitehead merged commit 75226af into openwallet-foundation:main Aug 20, 2024
29 checks passed

ff137 deleted the feat/order-by-scan branch August 20, 2024 22:33

ff137 added a commit to ff137/acapy that referenced this pull request Aug 21, 2024

🚧 test in-progress aries-askar PR: openwallet-foundation/askar#291

505dcd2

Signed-off-by: ff137 <ff137@proton.me>

ff137 added a commit to ff137/acapy that referenced this pull request Aug 29, 2024

🚧 test in-progress aries-askar PR: openwallet-foundation/askar#291

ee024d2

Signed-off-by: ff137 <ff137@proton.me>

TimoGlastra mentioned this pull request Sep 13, 2024

New release #309

Closed

ff137 added a commit to ff137/acapy that referenced this pull request Oct 22, 2024

🚧 test in-progress aries-askar PR: openwallet-foundation/askar#291

d00e0dd

Signed-off-by: ff137 <ff137@proton.me>

ff137 added a commit to didx-xyz/acapy that referenced this pull request Dec 2, 2024

construction: test in-progress aries-askar PR: openwallet-foundation/…

424a54d

…askar#291 Signed-off-by: ff137 <ff137@proton.me>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ add `order_by` and `descending` options to scan and fetch_all queries #291

✨ add `order_by` and `descending` options to scan and fetch_all queries #291

ff137 commented Jul 25, 2024 •

edited

Loading

ff137 commented Jul 26, 2024 •

edited

Loading

ff137 commented Jul 26, 2024

ff137 commented Aug 5, 2024 •

edited

Loading

ff137 commented Aug 15, 2024

ff137 commented Aug 16, 2024 •

edited

Loading

ff137 commented Aug 19, 2024

andrewwhitehead left a comment

✨ add order_by and descending options to scan and fetch_all queries #291

✨ add order_by and descending options to scan and fetch_all queries #291

Conversation

ff137 commented Jul 25, 2024 • edited Loading

ff137 commented Jul 26, 2024 • edited Loading

ff137 commented Jul 26, 2024

ff137 commented Aug 5, 2024 • edited Loading

ff137 commented Aug 15, 2024

ff137 commented Aug 16, 2024 • edited Loading

ff137 commented Aug 19, 2024

andrewwhitehead left a comment

Choose a reason for hiding this comment

✨ add `order_by` and `descending` options to scan and fetch_all queries #291

✨ add `order_by` and `descending` options to scan and fetch_all queries #291

ff137 commented Jul 25, 2024 •

edited

Loading

ff137 commented Jul 26, 2024 •

edited

Loading

ff137 commented Aug 5, 2024 •

edited

Loading

ff137 commented Aug 16, 2024 •

edited

Loading