Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Parse DateInt elements from number instead of string #531

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

cvarjao
Copy link
Contributor

@cvarjao cvarjao commented Nov 18, 2022

Signed-off-by: Clécio Varjão 1348549+cvarjao@users.noreply.github.com

Summary of Changes

Replace this text with a high-level summary of the changes included in this PR.

Related Issues

Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@cvarjao cvarjao marked this pull request as ready for review November 18, 2022 02:22
@cvarjao cvarjao requested a review from a team as a code owner November 18, 2022 02:22
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
@jleach jleach merged commit 0d21267 into openwallet-foundation:main Nov 21, 2022
@cvarjao cvarjao deleted the fix-dateint-parsing branch November 21, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants