Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pn)!: more services #115

Merged
merged 8 commits into from
May 27, 2022
Merged

feat(pn)!: more services #115

merged 8 commits into from
May 27, 2022

Conversation

berendsliedrecht
Copy link
Contributor

@berendsliedrecht berendsliedrecht commented May 12, 2022

  • Added apns service
  • Added fcm-android service
  • Will add a link to the RFCs when they are merged

BREAKING CHANGE: PushNotificationsModule does not exist anymore. You now have to use one that is specific to your service, e.g. PushNotificationsApnsModule or PushNotificationsFcmModule

Signed-off-by: Berend Sliedrecht <berend@animo.id>
Signed-off-by: Berend Sliedrecht <berend@animo.id>
Signed-off-by: Berend Sliedrecht <berend@animo.id>
Signed-off-by: Berend Sliedrecht <berend@animo.id>
Signed-off-by: Berend Sliedrecht <berend@animo.id>
Signed-off-by: Berend Sliedrecht <berend@animo.id>
@berendsliedrecht berendsliedrecht requested a review from a team as a code owner May 12, 2022 13:22
Signed-off-by: Berend Sliedrecht <berend@animo.id>
@berendsliedrecht
Copy link
Contributor Author

@TimoGlastra could you review this? It should be in sync again with the latest versions of the RFCs.

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #115 (deb3d68) into main (622c59e) will increase coverage by 2.94%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   86.19%   89.13%   +2.94%     
==========================================
  Files          41       43       +2     
  Lines         630      635       +5     
  Branches       92       91       -1     
==========================================
+ Hits          543      566      +23     
+ Misses         77       59      -18     
  Partials       10       10              
Impacted Files Coverage Δ
...ges/apns/PushNotificationsApnsDeviceInfoMessage.ts 100.00% <100.00%> (ø)
.../apns/PushNotificationsApnsGetDeviceInfoMessage.ts 100.00% <100.00%> (ø)
.../apns/PushNotificationsApnsSetDeviceInfoMessage.ts 100.00% <100.00%> (ø)
...ages/push-notifications/src/messages/apns/index.ts 100.00% <100.00%> (ø)
...sages/fcm/PushNotificationsFcmDeviceInfoMessage.ts 100.00% <100.00%> (ø)
...es/fcm/PushNotificationsFcmGetDeviceInfoMessage.ts 100.00% <100.00%> (ø)
...es/fcm/PushNotificationsFcmSetDeviceInfoMessage.ts 100.00% <100.00%> (ø)
...kages/push-notifications/src/messages/fcm/index.ts 100.00% <100.00%> (ø)
packages/push-notifications/src/messages/index.ts 100.00% <100.00%> (ø)
.../src/services/apns/PushNotificationsApnsService.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 622c59e...deb3d68. Read the comment docs.

packages/push-notifications/samples/sample.ts Outdated Show resolved Hide resolved
packages/push-notifications/samples/sample.ts Outdated Show resolved Hide resolved
Signed-off-by: Berend Sliedrecht <berend@animo.id>
@berendsliedrecht berendsliedrecht enabled auto-merge (squash) May 27, 2022 08:18
@berendsliedrecht berendsliedrecht merged commit dac5932 into openwallet-foundation:main May 27, 2022
janrtvld pushed a commit to janrtvld/aries-framework-javascript-ext that referenced this pull request Aug 26, 2022
Signed-off-by: Berend Sliedrecht <berend@animo.id>

BREAKING CHANGE: PushNotificationsModule does not exist anymore. You now have to use one that is specific to your service, e.g. PushNotificationsApnsModule or PushNotificationsFcmModule

Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants