fix(rest): changed webhook event topic to type #117
Conversation
janrtvld
force-pushed
the
fix/webhook-event-type
branch
from
af6c14e to
4fd7321
Compare
Codecov Report
@@ Coverage Diff @@
## main #117 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 43 43
Lines 635 635
Branches 91 84 -7
=======================================
Hits 566 566
Misses 59 59
Partials 10 10
Continue to review full report at Codecov.
|
packages/rest/tests/utils/agent.ts
Outdated
| @@ -43,8 +43,8 @@ export async function setupAgent({ | |||
| ], | |||
| publicDidSeed: publicDidSeed, | |||
| endpoints: endpoints, | |||
| autoAcceptConnections: autoAcceptConnection, | |||
| autoAcceptCredentials: autoAcceptCredential, | |||
| autoAcceptConnections: autoAcceptConnections, | |||
There was a problem hiding this comment.
| autoAcceptConnections: autoAcceptConnections, | |
| autoAcceptConnections, |
packages/rest/tests/utils/agent.ts
Outdated
| autoAcceptConnection: boolean | ||
| autoAcceptCredential: AutoAcceptCredential | ||
| autoAcceptConnections: boolean | ||
| autoAcceptCredentials: AutoAcceptCredential |
There was a problem hiding this comment.
Maybe just pass the one object that would contain the InitConfig. Or change some properties to be required with a custom type so that these issues will not occur.
There was a problem hiding this comment.
As this is just used for the sample and testing i have now removed most of the props to make it look cleaner.
packages/rest/package.json
Outdated
| "express": "^4.17.1", | ||
| "node-fetch": "^2.6.7", | ||
| "express": "^4.18.1", | ||
| "node-fetch": "2.6.7", |
There was a problem hiding this comment.
Is it intentional to remove the ^?
There was a problem hiding this comment.
node-fetch 3.0.0 has some issues, but just learned ^ doesn't update to major version so ill put it back :).
Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com>
Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com>
janrtvld
force-pushed
the
fix/webhook-event-type
branch
from
7306f87 to
bf66cba
Compare
Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com>
…#117) Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com>
Signed-off-by: Jan 60812202+janrtvld@users.noreply.github.com